fix(validation): Override route by annotation in translation of ingresses and httproutes for validation #7346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7346 +/- ##
=======================================
+ Coverage 77.2% 77.3% +0.1%
=======================================
Files 220 220
Lines 25309 25311 +2
=======================================
+ Hits 19542 19585 +43
+ Misses 4773 4733 -40
+ Partials 994 993 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
randmonkey
force-pushed
the
fix/fti-6622-validate-ingress-protocols
branch
from
b8a7401 to
be905b7
Compare
pmalek
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Override translated Kong routes with annotations in validation webhooks for
Ingresses andHTTPRoutes.Which issue this PR fixes:
Fixes #7344
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR