Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24 #155

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Fixes #24 #155

merged 1 commit into from
Nov 2, 2024

Conversation

RhiyaBhat
Copy link
Contributor

Description

he current color palette used in the CLI outputs is inconsistent, making it difficult for users to differentiate between various types of messages (e.g., informational, warning, success). The new palette should provide clear visual distinctions for different message types and maintain accessibility standards.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have maintained a clean commit history by using the necessary Git commands
  • I have checked that my code does not cause any merge conflicts

@Kota-Karthik
Copy link
Owner

@RhiyaBhat
can you just add screenshots to show us how the new color palette look for different situations?

@Wahid7852
Copy link
Collaborator

Waiting for your response @RhiyaBhat

@Wahid7852
Copy link
Collaborator

if no response in 24 hours @RhiyaBhat. i will be closing it

@RhiyaBhat
Copy link
Contributor Author

@RhiyaBhat can you just add screenshots to show us how the new color palette look for different situations?

Is it not working in other devices?

@techy4shri
Copy link
Collaborator

@RhiyaBhat it is contribution rule to add media and follow PR template while raising one. You have 24 hours to comply or I will be closing this PR. If you have a question or doubt, ask them on discord for more details or here.

@techy4shri techy4shri added the changes requested changes requested in the pull request to make it eligible for merging. label Nov 1, 2024
@RhiyaBhat
Copy link
Contributor Author

image

INFO_COLOR = 'blue'
WARNING_COLOR = 'yellow'
SUCCESS_COLOR = 'green'
ERROR_COLOR = 'red'

Copy link
Owner

@Kota-Karthik Kota-Karthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RhiyaBhat
LGTM!

@Kota-Karthik Kota-Karthik merged commit ae1a7ad into Kota-Karthik:main Nov 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested changes requested in the pull request to make it eligible for merging. gssoc-ext hacktoberfest-accepted hard level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Inconsistent Color Palette with an Optimal Color Palette for CLI Outputs
4 participants