Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dry-run Functionality to TwinTrim for Safe Simulated Duplicate Removal #74

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

adityakalburgi
Copy link
Contributor

@adityakalburgi adityakalburgi commented Oct 5, 2024

This PR introduces a --dry-run option to TwinTrim, allowing users to simulate the duplicate removal process without making any changes. The feature is designed to give users a safe preview of what actions will be taken, ensuring they can confidently proceed with the actual duplicate removal process.

Key Changes:
Added the --dry-run flag to simulate file deletions.
Updated the core logic to handle the dry run mode.
Modified the README to include documentation

resolves issue #58

@Kota-Karthik
Copy link
Owner

@adityakalburgi
can you please add screenshots , for showing us how this new --dry-run mode looks

@adityakalburgi
Copy link
Contributor Author

ok will share it

@adityakalburgi
Copy link
Contributor Author

Hi! @Kota-Karthik here is the screenshort how it works

  1. when there were no duplicates in my directory
  2. when i created duplicate in my directory
    Screenshot 2024-10-06 192359
    Screenshot 2024-10-06 192924

Copy link
Collaborator

@techy4shri techy4shri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make these changes and wait for further review.

Copy link
Contributor Author

@adityakalburgi adityakalburgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have done the required changes

Copy link
Collaborator

@techy4shri techy4shri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see the changes in option seciton in readme yet, kindly implement it.

@adityakalburgi
Copy link
Contributor Author

@techy4shri DONE!! I have added it in option section..

Copy link
Collaborator

@techy4shri techy4shri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Everything is great! Thank you @adityakalburgi

@techy4shri techy4shri merged commit b5e7b8c into Kota-Karthik:main Oct 7, 2024
2 checks passed
@Kota-Karthik Kota-Karthik removed enhancement New feature or request level3 labels Oct 8, 2024
@adityakalburgi
Copy link
Contributor Author

Hi! @Kota-Karthik can you please explain me what the issue is?..

@Kota-Karthik
Copy link
Owner

@adityakalburgi go through the changes you made and try to run the project
You will notice , you have many errors in updated code
you can check your code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants