feat: change dependency visibility to api for submodules (#183)

Kr1ptal · Oct 18, 2024 · d0e73ca · d0e73ca
1 parent ab516a6
commit d0e73ca
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 20 deletions.
diff --git a/ethers-abi/build.gradle.kts b/ethers-abi/build.gradle.kts
@@ -7,9 +7,9 @@ plugins {
 }
 
 dependencies {
-    implementation(project(":ethers-core"))
-    implementation(project(":ethers-providers"))
-    implementation(project(":ethers-signers"))
+    api(project(":ethers-core"))
+    api(project(":ethers-providers"))
+    api(project(":ethers-signers"))
 
     testImplementation(libs.bundles.kotest)
 

diff --git a/ethers-abigen-plugin/build.gradle.kts b/ethers-abigen-plugin/build.gradle.kts
@@ -7,7 +7,8 @@ plugins {
 }
 
 dependencies {
-    implementation(project(":ethers-abigen"))
+    api(project(":ethers-abigen"))
+
     implementation(libs.kotlin.gradle)
     implementation(libs.hoplite.core)
     implementation(libs.hoplite.toml)

diff --git a/ethers-abigen/build.gradle.kts b/ethers-abigen/build.gradle.kts
@@ -4,10 +4,9 @@ plugins {
 }
 
 dependencies {
-    implementation(project(":ethers-core"))
-    implementation(project(":ethers-providers"))
-    implementation(project(":ethers-signers"))
-    implementation(project(":ethers-abi"))
+    api(project(":ethers-core"))
+    api(project(":ethers-providers"))
+    api(project(":ethers-abi"))
 
     implementation(libs.kotlinpoet) {
         // don't need this dependency: https://square.github.io/kotlinpoet/#kotlin-reflect

diff --git a/ethers-crypto/src/main/kotlin/io/ethers/crypto/ECDSASignerRecoverable.kt b/ethers-crypto/src/main/kotlin/io/ethers/crypto/ECDSASignerRecoverable.kt
@@ -31,7 +31,7 @@ import java.security.SecureRandom
  *
  * Original: [org.bouncycastle.crypto.signers.ECDSASigner]
  */
-class ECDSASignerRecoverable : ECConstants, DSAExt {
+internal class ECDSASignerRecoverable : ECConstants, DSAExt {
     private val kCalculator: DSAKCalculator
     private var key: ECKeyParameters? = null
     private var random: SecureRandom? = null

diff --git a/ethers-ens/build.gradle.kts b/ethers-ens/build.gradle.kts
@@ -9,9 +9,10 @@ repositories {
 }
 
 dependencies {
-    implementation(project(":ethers-core"))
-    implementation(project(":ethers-abi"))
-    implementation(project(":ethers-providers"))
+    api(project(":ethers-core"))
+    api(project(":ethers-abi"))
+    api(project(":ethers-providers"))
+
     implementation(project(":logger"))
     implementation(libs.ens.normalise)
 

diff --git a/ethers-providers/build.gradle.kts b/ethers-providers/build.gradle.kts
@@ -10,8 +10,9 @@ repositories {
 dependencies {
     api(libs.bundles.okhttp3)
 
-    implementation(project(":ethers-core"))
-    implementation(project(":ethers-signers"))
+    api(project(":ethers-core"))
+    api(project(":ethers-signers"))
+
     implementation(project(":logger"))
     implementation(libs.jctools)
     implementation(libs.bundles.jackson)

diff --git a/ethers-signers-gcp/build.gradle.kts b/ethers-signers-gcp/build.gradle.kts
@@ -4,9 +4,7 @@ plugins {
 }
 
 dependencies {
-    implementation(project(":ethers-core"))
-    implementation(project(":ethers-crypto"))
-    implementation(project(":ethers-signers"))
+    api(project(":ethers-signers"))
 
     implementation(libs.bouncycastle.provider)
     implementation(libs.gcp.kms)

diff --git a/ethers-signers/build.gradle.kts b/ethers-signers/build.gradle.kts
@@ -4,9 +4,8 @@ plugins {
 }
 
 dependencies {
-    implementation(project(":ethers-core"))
-    implementation(project(":ethers-crypto"))
-    implementation(project(":ethers-rlp"))
+    api(project(":ethers-core"))
+    api(project(":ethers-crypto"))
 
     implementation(libs.bouncycastle.provider)