From d0e73ca4ac87d90be97cdc3cee3491fb7afd2ccd Mon Sep 17 00:00:00 2001 From: ArtificialPB Date: Sat, 19 Oct 2024 00:28:45 +0200 Subject: [PATCH] feat: change dependency visibility to `api` for submodules (#183) --- ethers-abi/build.gradle.kts | 6 +++--- ethers-abigen-plugin/build.gradle.kts | 3 ++- ethers-abigen/build.gradle.kts | 7 +++---- .../main/kotlin/io/ethers/crypto/ECDSASignerRecoverable.kt | 2 +- ethers-ens/build.gradle.kts | 7 ++++--- ethers-providers/build.gradle.kts | 5 +++-- ethers-signers-gcp/build.gradle.kts | 4 +--- ethers-signers/build.gradle.kts | 5 ++--- 8 files changed, 19 insertions(+), 20 deletions(-) diff --git a/ethers-abi/build.gradle.kts b/ethers-abi/build.gradle.kts index 81e42d60..a09b9102 100644 --- a/ethers-abi/build.gradle.kts +++ b/ethers-abi/build.gradle.kts @@ -7,9 +7,9 @@ plugins { } dependencies { - implementation(project(":ethers-core")) - implementation(project(":ethers-providers")) - implementation(project(":ethers-signers")) + api(project(":ethers-core")) + api(project(":ethers-providers")) + api(project(":ethers-signers")) testImplementation(libs.bundles.kotest) diff --git a/ethers-abigen-plugin/build.gradle.kts b/ethers-abigen-plugin/build.gradle.kts index b0b165ea..daf635c7 100644 --- a/ethers-abigen-plugin/build.gradle.kts +++ b/ethers-abigen-plugin/build.gradle.kts @@ -7,7 +7,8 @@ plugins { } dependencies { - implementation(project(":ethers-abigen")) + api(project(":ethers-abigen")) + implementation(libs.kotlin.gradle) implementation(libs.hoplite.core) implementation(libs.hoplite.toml) diff --git a/ethers-abigen/build.gradle.kts b/ethers-abigen/build.gradle.kts index 19789272..8e62f457 100644 --- a/ethers-abigen/build.gradle.kts +++ b/ethers-abigen/build.gradle.kts @@ -4,10 +4,9 @@ plugins { } dependencies { - implementation(project(":ethers-core")) - implementation(project(":ethers-providers")) - implementation(project(":ethers-signers")) - implementation(project(":ethers-abi")) + api(project(":ethers-core")) + api(project(":ethers-providers")) + api(project(":ethers-abi")) implementation(libs.kotlinpoet) { // don't need this dependency: https://square.github.io/kotlinpoet/#kotlin-reflect diff --git a/ethers-crypto/src/main/kotlin/io/ethers/crypto/ECDSASignerRecoverable.kt b/ethers-crypto/src/main/kotlin/io/ethers/crypto/ECDSASignerRecoverable.kt index d1c7796a..15148543 100644 --- a/ethers-crypto/src/main/kotlin/io/ethers/crypto/ECDSASignerRecoverable.kt +++ b/ethers-crypto/src/main/kotlin/io/ethers/crypto/ECDSASignerRecoverable.kt @@ -31,7 +31,7 @@ import java.security.SecureRandom * * Original: [org.bouncycastle.crypto.signers.ECDSASigner] */ -class ECDSASignerRecoverable : ECConstants, DSAExt { +internal class ECDSASignerRecoverable : ECConstants, DSAExt { private val kCalculator: DSAKCalculator private var key: ECKeyParameters? = null private var random: SecureRandom? = null diff --git a/ethers-ens/build.gradle.kts b/ethers-ens/build.gradle.kts index 1084c090..44641ccb 100644 --- a/ethers-ens/build.gradle.kts +++ b/ethers-ens/build.gradle.kts @@ -9,9 +9,10 @@ repositories { } dependencies { - implementation(project(":ethers-core")) - implementation(project(":ethers-abi")) - implementation(project(":ethers-providers")) + api(project(":ethers-core")) + api(project(":ethers-abi")) + api(project(":ethers-providers")) + implementation(project(":logger")) implementation(libs.ens.normalise) diff --git a/ethers-providers/build.gradle.kts b/ethers-providers/build.gradle.kts index 0269f06a..c49d066a 100644 --- a/ethers-providers/build.gradle.kts +++ b/ethers-providers/build.gradle.kts @@ -10,8 +10,9 @@ repositories { dependencies { api(libs.bundles.okhttp3) - implementation(project(":ethers-core")) - implementation(project(":ethers-signers")) + api(project(":ethers-core")) + api(project(":ethers-signers")) + implementation(project(":logger")) implementation(libs.jctools) implementation(libs.bundles.jackson) diff --git a/ethers-signers-gcp/build.gradle.kts b/ethers-signers-gcp/build.gradle.kts index 15e537ac..38186ef4 100644 --- a/ethers-signers-gcp/build.gradle.kts +++ b/ethers-signers-gcp/build.gradle.kts @@ -4,9 +4,7 @@ plugins { } dependencies { - implementation(project(":ethers-core")) - implementation(project(":ethers-crypto")) - implementation(project(":ethers-signers")) + api(project(":ethers-signers")) implementation(libs.bouncycastle.provider) implementation(libs.gcp.kms) diff --git a/ethers-signers/build.gradle.kts b/ethers-signers/build.gradle.kts index e4d7644c..56cbd51a 100644 --- a/ethers-signers/build.gradle.kts +++ b/ethers-signers/build.gradle.kts @@ -4,9 +4,8 @@ plugins { } dependencies { - implementation(project(":ethers-core")) - implementation(project(":ethers-crypto")) - implementation(project(":ethers-rlp")) + api(project(":ethers-core")) + api(project(":ethers-crypto")) implementation(libs.bouncycastle.provider)