Initialize ALL DSP registers on boot instead of just a pre-defined list #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent any uninitialized DSP registers from causing shenanigans down the road. Additionally, this actually saves a few bytes. All of the DSP register values are covered in their original values except for the DIR DSP register: the reason why DIR isn't covered is because it is automatically set upon loading a piece of music, and no samples are currently pre-loaded either. To avoid a possible accidental out-of-bounds case that occurred in vanilla SMW, one additional entry has been added to the PanValues table so that $14 is handled like it was previously. All other out-of-bounds cases will not be supported as the build changes over time. This commit closes #453.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent any uninitialized DSP registers from causing shenanigans down the road. Additionally, this actually saves a few bytes. All of the DSP register values are covered in their original values except for the DIR DSP register: the reason why DIR isn't covered is because it is automatically set upon loading a piece of music, and no samples are currently pre-loaded either.
To avoid a possible accidental out-of-bounds case that occurred in vanilla SMW, one additional entry has been added to the PanValues table so that $14 is handled like it was previously. All other out-of-bounds cases will not be supported as the build changes over time.
This commit closes #453.