Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded dependencies #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

sm2017
Copy link

@sm2017 sm2017 commented Jul 13, 2019

Upgraded dependencies
See Kurento/bugtracker#386 for more details

I hope we have no issue with "websocket-stream": "~5.5.0" , I know that we have issue with "websocket-stream": "~0.5.1"

https://github.com/KurentoForks/reconnect-ws/blob/master/index.js#L12
I dont find _buffer in "websocket-stream": "~5.5.0" is it important?

@JoseGoncalves
Copy link

@sm2017 I think you can drop ws in devDependencies as this is pulled by websocket-stream.
The only direct dependencies for this package are websocket-stream and reconnect-core.

@sm2017
Copy link
Author

sm2017 commented Aug 23, 2019

@JoseGoncalves done

@JoseGoncalves
Copy link

Tried to use v5.5.0 of websocket-stream in my app using Kurento 6.11 and had some issues with it.
Reverted to v3.3.3 which works perfectly in my use case.

@JoseGoncalves
Copy link

JoseGoncalves commented Aug 26, 2019

_buffer is part of the BufferPool class that was removed in ws v2.

So, to be able to upgrade websocket-stream to something higher than v3.3.3 (the last version that depends on ws v1) the code in index.js from the reconnect-ws package must be adapted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants