Fix clang format conflicts un unchecked policy branch #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a macro to generate the various aliases
This iteration mapping assumes that the number of iterations is the same as the size of the range and does no checking. This is useful when mapping gpu blocks as we often launch the exact number we need and don't need to check if we are in range. This can give ~5% speedup vs direct in this case.
There were a number missing for cuda/hip
This adds testing for unchecked policies with cuda and hip in kernel and launch.
Fix some merge conflicts. More work to do...
|
This PR has a large number of small changes, notably the date changes. I thought dates had been previously updated? |
MrBurmark
changed the title
|
This is mainly to make sure that we're happy with the way the merge conflicts were handled, but there are too many formatting changes in this PR to actually look at that. I'm trying to figure out the failing test, but I'll close this for now. |
MrBurmark
changed the base branch from
feature/burmark1/unchecked_policies
to
develop
|
I changed the base to develop to better see the changes. |
|
@artv3 can you double check that this has all the policies that you think it should have? I'm pretty sure that this has strictly more than existed before. |
|
This is failing a test due to this issue and hopefully not anything intrinsic to these changes. #1733 |
…ng/clang-format-conflicts
…ng-format-conflicts
artv3
approved these changes
Feb 18, 2025
rchen20
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix merge conflicts caused by clang format changes