Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AXOM_ENABLE_ASAN CMake option #1484

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Add AXOM_ENABLE_ASAN CMake option #1484

merged 5 commits into from
Jan 3, 2025

Conversation

white238
Copy link
Member

@white238 white238 commented Jan 2, 2025

This makes enabling Address Sanitizer builds easier and adds documentation for how to do it and also use Valgrind.

@gunney1

@white238 white238 added enhancement New feature or request Testing Issues related to testing Axom Documentation Issues related to documentation Software process Issues related to processes for software development User Request Issues related to user requests compiler Related to various compilers and their quirks nice to have memory labels Jan 2, 2025
@white238
Copy link
Member Author

white238 commented Jan 2, 2025

https://axom.readthedocs.io/en/feature-white238-enable_asan/docs/sphinx/dev_guide/memory_checking.html

kennyweiss
kennyweiss approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @white238

gunney1
gunney1 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@gunney1 gunney1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @white238 !

@white238 white238 merged commit 511ae0a into develop Jan 3, 2025
13 checks passed
@white238 white238 deleted the feature/white238/enable_asan branch January 3, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyweiss kennyweiss kennyweiss approved these changes

@gunney1 gunney1 gunney1 approved these changes

@rhornung67 rhornung67 Awaiting requested review from rhornung67

Assignees
No one assigned
Labels
compiler Related to various compilers and their quirks Documentation Issues related to documentation enhancement New feature or request memory nice to have Software process Issues related to processes for software development Testing Issues related to testing Axom User Request Issues related to user requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@white238 @kennyweiss @gunney1