Verify ReportId (#740)

avoid NPE for bad values
LabKey · Mar 21, 2024 · 99a90c3 · 99a90c3
1 parent 947e012
commit 99a90c3
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/flow/src/org/labkey/flow/reports/FlowReport.java b/flow/src/org/labkey/flow/reports/FlowReport.java
@@ -115,6 +115,8 @@ protected void updateBaseProperties(ContainerUser cu, PropertyValues pvs, BindEx
     @Override
     public ActionURL getRunReportURL(ViewContext context)
     {
+        if (null == getReportId())
+            return null;
         Container c = ContainerManager.getForId(getDescriptor().getContainerId());
         ActionURL url = new ActionURL(ReportsController.ExecuteAction.class, c);
         url.addParameter("reportId", getReportId().toString());
@@ -129,6 +131,8 @@ public ActionURL getRunReportURL(ViewContext context)
     @Override
     public ActionURL getEditReportURL(ViewContext context)
     {
+        if (null == getReportId())
+            return null;
         Container c = ContainerManager.getForId(getDescriptor().getContainerId());
         ActionURL url = new ActionURL(ReportsController.UpdateAction.class, c);
         url.addParameter("reportId", getReportId().toString());