Issue 46774: Remove Ruminex package references from Luminex transform script #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kwards compatibility
…ings report if curve fit data not present
…ings report if curve fit data not present
cnathe
requested review from
labkey-jeckels and
labkey-klum
and removed request for
labkey-jeckels
labkey-klum
approved these changes
Feb 9, 2023
14 tasks
labkey-tchad
pushed a commit
that referenced
this pull request
Feb 24, 2023
… script (#578) - Remove Ruminex package usage and calculations from labkey_luminex_transform.R - Remove Ruminex related props from Luminex test assay configurations and validation checks - Hide EC50 4PL/5PL related columns and guide set inputs for Levey-Jennings report if curve fit data not present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=46774
The Ruminex package is no longer maintained and the EC50 5PL generated curve fits have never actually been used by the clients, so we are removing support for this package in our standard labkey_luminex_transform.R assay transform script. This PR also updates the Levey-Jennings report so that it checks if curve fit data exists for 4PL and 5PL curve types, and if not, hides the data columns and UI elements related to those EC50 values.
Related Pull Requests
Changes