Improve upgrade workflow for embedded Tomcat #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
14 tasks
labkey-susanh
approved these changes
Mar 6, 2024
|
|
||
| context.encryptionKey=@@encryptionKey@@ | ||
|
|
||
| ## By default, we deploy to the root context path. However, some servers have historically used /labkey or even /cpas |
There was a problem hiding this comment.
Since this is to be included with a distribution, I think this comment should be updated to instruct users on intended usage, not historical context.
| @@ -459,8 +463,7 @@ class ModuleDistribution extends DefaultTask | |||
| } | |||
|
|
|||
| tarfileset(dir: BuildUtils.getBuildDirFile(project, "embedded"), prefix: archiveName) { | |||
| // include(name: "manual-upgrade.sh") | |||
| include(name: "README.txt") | |||
| exclude(name: "manual-upgrade.sh") | |||
There was a problem hiding this comment.
Is this file still present in the embedded directory?
# Conflicts: # README.md # build.gradle
# Conflicts: # README.md # src/main/groovy/org/labkey/gradle/task/ModuleDistribution.groovy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
LabKey/server#725
Related Pull Requests
Changes
application.propertiesin embedded distributionslabkeyServer.jarstartTomcattask work for embedded Tomcat on WindowsVERSIONfile in executable server jar