Support finding samples with multiple parent matches #1391
Conversation
| } | ||
| } | ||
|
|
||
| if (missingValueError == true) { |
There was a problem hiding this comment.
| if (missingValueError == true) { | |
| if (missingValueError) { |
| }); | ||
| return 'Missing filter values for: ' + parentMsgs.join('; ') + '.'; | ||
| } | ||
|
|
||
| if (maxMatchAllErrorField) | ||
| return ( | ||
| "A max of 10 values can be selected for 'Equals All Of' filter type for '" + maxMatchAllErrorField + "'." |
There was a problem hiding this comment.
| "A max of 10 values can be selected for 'Equals All Of' filter type for '" + maxMatchAllErrorField + "'." | |
| "At most 10 values can be selected for 'Equals All Of' filter type for '" + maxMatchAllErrorField + "'." |
| const filterType = | ||
| newFilterType?.value === ANCESTOR_MATCHES_ALL_OF_FILTER_TYPE.getURLSuffix() | ||
| ? ANCESTOR_MATCHES_ALL_OF_FILTER_TYPE | ||
| : resolveFilterType(newFilterType?.value, field); |
There was a problem hiding this comment.
Does it make sense to incorporate the check for ANCESTOR_MATCHES_ALL into resolveFilterType?
| // skip optimization for ANCESTOR_MATCHES_ALL filter type | ||
| if (isAncestorMatchesAllFilter) { | ||
| if ((newValue === ALL_VALUE_DISPLAY && !check) || newCheckedValues.length === 0) | ||
| return Filter.create(fieldKey, [], ANCESTOR_MATCHES_ALL_OF_FILTER_TYPE); |
There was a problem hiding this comment.
I'm probably not reading this properly, but doesn't this result in a "no filter value" error for the filter? Seems like we would return null here but maybe we want to show the error.
There was a problem hiding this comment.
The idea is to retain the filter type when user is on Choose Value tab . If we return null, the filter will get automatically get changed to equals (one of) as user starts to select value.
| const filterType = filter.getFilterType(); | ||
| const columnNameSelect = getLegalIdentifier(filter.getColumnName(), tableAlias); | ||
| let operatorSql = null; | ||
|
|
||
| const values = filterType.parseValue(filter.getValue()); | ||
|
|
||
| const sqlValues = []; | ||
| const negate = filterType.getURLSuffix() === Filter.Types.NOT_IN.getURLSuffix(); | ||
| const negate = filterType.getURLSuffix() === Filter.Types.NOT_IN.getURLSuffix() && !noNegate; |
There was a problem hiding this comment.
A triple negative! Can we be more positive somehow? The flipNegative from the calling methods reads better to me.
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
# Conflicts: # package-lock.json # package.json
Rationale
A sample may have multiple parents from the same data type. This PR adds support to find samples in Sample Finder by matching multiple parents using a new "Equals All Of" filter type. This new filter type will be available for parent cards only and is currently limited to the Name/Id columns.
Related Pull Requests
Changes