Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown Menus #1396

Merged
merged 70 commits into from
Jan 29, 2024
Merged

Dropdown Menus #1396

merged 70 commits into from
Jan 29, 2024

Conversation

labkey-alan
Copy link
Contributor

@labkey-alan labkey-alan commented Jan 19, 2024 •
edited
Loading

Rationale

This PR adds internal versions of DropdownButton, SplitButton, MenuItem, DropdownAnchor

Note: This PR will not be updating SubMenu, SubMenuItem, ResponsiveMenuButtonGroup, or ResponsiveMenuButton, as they are particularly complicated (and flawed) usages of DropdownButton and MenuItem. I will be refactoring them in a follow-on PR.

Related Pull Requests

Changes

  • Remove MultiMenuButton
    • it was unused
  • Add DropdownButton
  • Add DropdownAnchor
  • Add SplitButton
  • Add MenuItem
  • Add MenuHeader
  • Add MenuDivider
  • Update usages of react-bootstrap DropdownButton, SplitButton, MenuItem to internal versions
  • ManageDropdownMenu: remove all props

@labkey-alan labkey-alan self-assigned this Jan 19, 2024
@labkey-alan labkey-alan mentioned this pull request Jan 22, 2024
Merged
@labkey-alan labkey-alan marked this pull request as ready for review January 23, 2024 23:49
@labkey-alan
Add internal version of DropdownButton and MenuItem
fd75d7c 
Also add MenuHeader and MenuDivider
@labkey-alan
useOverlayTriggerState - return mouseOut instead of mouseLeave
7efd907
@labkey-alan
useOverlayPositioning - Add warning when targetRef is not passed
191b7fb
@labkey-alan
ProductNavigation.tsx: add TODO
3b1e690
@labkey-alan
ProductMenu: add TODO
becec74
@labkey-alan
Delete MultiMenuButton (unused)
eca071c
@labkey-alan
Add styling for internal version of Dropdown Menus
027a956
@labkey-alan
PageMenu, ExportMenu, ViewMenu - use internal version of DropdownMenu…
f661e9d 
…/MenuItem
@labkey-alan
DisableableButton - use onMouseOut
e169668
@labkey-alan
SubMenu/SubMenuItem: Add FIXMEs
4664550
@labkey-alan
ManageDropdownButton - Use internal DropdownButton, remove id prop
8975845
@labkey-alan
QueryModel: don't return id as part of PaginationData
34299ae 
It is no longer necessary
@labkey-alan
Remove SplitButtonGroup, add SplitButton
f7fe635
@labkey-alan
Export DropdownButton, SplitButton, MenuItem, MenuHeader, MenuDivider
d4e134d
@labkey-alan
MenuItem: add title prop
98b7c14
@labkey-alan
GridPanel: use internal SplitButton and MenuItem
4c45bfc
@labkey-alan
SplitButton: support href
a054421
@labkey-alan
SampleAliquotViewSelector: add TODO, use ===
54f3199
@labkey-alan
Update release notes
65db9b9
@labkey-alan
BarChartViewer: Use internal DropdownButton, MenuItem
010c8d6
@labkey-alan
SampleAliquotViewSelector: Use internal DropdownButton, MenuItem
a7599bc 
Also convert to FC
@labkey-alan
FindAndSearchDropdown: Use internal DropdownButton, MenuItem
fb3c274
@labkey-alan
VisGraphControls: Use internal DropdownButton, MenuItem
91ac5fd
@labkey-alan
UserMenuGroup: Update class names
5caf22a
@labkey-alan
Fix navbar styles
1a7b6a2
@labkey-alan
ManageDropdownButton.spec.tsx - delete tests, they're no longer relevant
92fa168
@labkey-alan
ChartMenu: Use internal versions of DropdownButton and MenuItem
bb5b457
@labkey-alan
renderers.tsx - Use internal MenuItem
16e25e1
@labkey-alan
ResponsiveMenuButton: Add TODO
be5bb1b
@labkey-alan
ResponsiveMenuButtonGroup: Add TODO
6601abd
@labkey-alan
GroupManagementPage: use internal version of MenuItem
562dedd
@labkey-alan
UserManagement - use internal version of MenuItem
fb19957
@labkey-alan
SubMenu: Add TODO
e618546
@labkey-alan
SelectionMenuItem.spec.tsx don't use MenuItem
457ef32
@labkey-alan
UserMenuGroup.spec.tsx - User internal components
9c2d216
@labkey-alan
ServerNotifications: Add TODO
579cdd2
@labkey-alan
PageMenu.spec.tsx - use internal components
7e9905b
@labkey-alan
Picklist menu items: User internal MenuItem
1fae2c1
@labkey-alan
UsersGridPanel: Use internal MenuItem
7565a87
@labkey-alan
DropdownButton: Add optional onClick prop
996a1ea
@labkey-alan
Fix issue with popover size
a56f683
@labkey-alan
Update styling for toolbar menus
eaef4a3
@labkey-alan
PR Feedback
ae907fd
@labkey-alan
Fix tests
9e24b21
@labkey-alan
SchemaBrowserRoutes - Remove test code
a50d235
@labkey-alan
DisableableMenuItem - add displayName
2c82731
@labkey-alan
preventDocumentHandler: Fix issue with tests
f280415
@labkey-alan
ManageDropdownButton: Add displayName
6630169
@labkey-alan
Prep for release
a525f25
@labkey-alan labkey-alan merged commit 47c1b6d into develop Jan 29, 2024
1 check passed
@labkey-alan labkey-alan deleted the fb_dropdowns branch January 29, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-nicka labkey-nicka labkey-nicka approved these changes

@cnathe cnathe Awaiting requested review from cnathe

Assignees

@labkey-alan labkey-alan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-alan @labkey-nicka