DropdownSection #1409
Merged
DropdownSection #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-alan
force-pushed
the
fb_submenu
branch
from
70e087d to
132a4f4
Compare
cnathe
approved these changes
Feb 8, 2024
| <MenuItem> | ||
| <input | ||
| onChange={onFilterChange} | ||
| onClick={onFilterClick} |
There was a problem hiding this comment.
the onclick for this filter input just calls preventDocumentHandler. Is that needed? I wouldn't have expected this input to need any onClick handler.
There was a problem hiding this comment.
It is needed or clicking on the filter input will close the menu
| @@ -190,7 +190,7 @@ export const FindDerivativesMenuItem: FC<Props> = memo(props => { | |||
|
|
|||
| return ( | |||
| <DisableableMenuItem | |||
| operationPermitted={!invalidFilterNames} | |||
| disabled={invalidFilterNames !== ''} | |||
There was a problem hiding this comment.
can invalidFilterNames be undefined?
There was a problem hiding this comment.
No because it's calculated from an array.join(',') on an array that is always defined and defaults to [].
| @@ -324,6 +324,8 @@ export const FilterExpressionView: FC<Props> = memo(props => { | |||
| const expanded = expandedOntologyKey === ontologyBrowserKey; | |||
| // FIXME: This is not a proper usage of Dropdown, as it is not rendering any MenuItems this behavior | |||
| // should be accomplished some other way (OverlayTrigger + Popover with click events?) | |||
| // Note: we can just replace this with some basic logic to show/hide it and render it inline, it does | |||
| // not need to render as a floating item, so Dropdown is very unnecessary. | |||
There was a problem hiding this comment.
I assume this is for another / separate PR?
There was a problem hiding this comment.
Yep, going to handle this case with the ProductMenu et. al.
labkey-alan
force-pushed
the
fb_submenu
branch
from
5745ef0 to
864d847
Compare
It is unused
labkey-alan
force-pushed
the
fb_submenu
branch
from
864d847 to
72e17b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This PR adds DropdownSection as a replacement for SubMenu so we can remove all remaining usages of DropdownButton and MenuItem from react-bootstrap.
Related Pull Requests
Changes