Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support finding samples with multiple parent matches #5120

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

XingY
Copy link
Contributor

@XingY XingY commented Jan 11, 2024

Rationale

We are adding a new "Equals all of" filter type for sample finder's parent cards to allow finding samples with multiple ancestors. The values in "Equals all of" filter is used to generate an array of inexpdescendantsof filters to find the matched results. We additionally allow a second (AND) filter for each field. When a negative (neq, not in) type filter is used in combination with "Equals all of" filter, we would want to make sure "notinexpdescendantsof" instead of "inexpdescendantsof" for the second filter to correctly further filter the multi-value field.

The scenario would be:
Patient Equals All Of ("Mouse-1", "Mouse-2)
AND Patient <> "Mouse-3"

The expected filter array should be

  • inexpdescendantsof " ... = Mouse-1"
  • inexpdescendantsof " ... = Mouse-2"
  • notinexpdescendantsof "... = Mouse-3"

Instead of

  • inexpdescendantsof "... = Mouse-1"
  • inexpdescendantsof "... =Mouse-2"
  • inexpdescendantsof " ... <> Mouse-3"

Related Pull Requests

Changes

  • add support for notinexpdescendantsof operator type

@XingY XingY marked this pull request as ready for review January 12, 2024 00:07
@XingY XingY requested a review from labkey-susanh January 12, 2024 18:37
@XingY XingY merged commit 8622f0d into develop Jan 15, 2024
2 checks passed
@XingY XingY deleted the fb_multiAncestors branch January 15, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants