Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 49167: Match field names with new lines as well as spaces #5195

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Issue 49167: Match field names with new lines as well as spaces #5195

merged 2 commits into from
Feb 6, 2024

Conversation

labkey-susanh
Copy link
Contributor

@labkey-susanh labkey-susanh commented Feb 5, 2024 •
edited
Loading

Rationale

Issue 49167

Related Pull Requests

Changes

  • Update DataLoader.java to replace newLines in field names with spaces
  • Update test to verify the mapping for Excel

@labkey-susanh labkey-susanh mentioned this pull request Feb 5, 2024
Merged
labkey-matthewb
labkey-matthewb approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@labkey-matthewb labkey-matthewb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long before we hear about some column name with a double space in the name.

@labkey-susanh labkey-susanh merged commit 858cf61 into develop Feb 6, 2024
4 of 6 checks passed
@labkey-susanh labkey-susanh deleted the fb_fieldNameNewLines branch February 6, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-matthewb labkey-matthewb labkey-matthewb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-susanh @labkey-matthewb