Improve upgrade workflow for embedded Tomcat #5295
Conversation
…fb_embedded_upgradeImprovements
…fb_embedded_upgradeImprovements
…fb_embedded_upgradeImprovements
| File indexParent = FileContentService.get() != null | ||
| ? FileContentService.get().getSiteDefaultRoot() | ||
| : FileUtil.getTempDirectory(); | ||
| return new File(indexParent, ".labkey_full_text_index").getPath(); |
There was a problem hiding this comment.
@labkey-stuartm @labkey-jony any preferences on how to name this file? With or without the . prefix?
There was a problem hiding this comment.
I mostly added that so that it wouldn't show up in the webdav browser. (I think it excludes dot files)
There was a problem hiding this comment.
Yes, I think you're right - those are hidden in the webdav UI.
However, I hope these files won't be exposed anyway. They're not in an @files subdirectory, are they?
There was a problem hiding this comment.
You're correct, they are not exposed. I was just confused by seeing the @files directories in the webdav UI and assumed it was directly showing the file system. Further investigation does make me realize that there is a possibility of colliding with a project folder.
In order to avoid that, I see a few obvious solutions.
- Use a folder name that is already reserved (e.g.
@labkey_full_text_index) - Add
.labkey_full_text_indexto the list of reserved project names (consider removing the.) - Choose an entirely different location, maybe a sibling of
files
There was a problem hiding this comment.
I vote for @labkey_full_text_index. On some deployments, the file root is a mount point on the file system. I think by default having the full text search land on the same file system is a good default.
There was a problem hiding this comment.
That was my thought as well. Thank you
…fb_embedded_upgradeImprovements
Rationale
Making migration from standalone to embedded tomcat a little smoother
Related Pull Requests
Changes