ExpMaterialTable: consistent initialization #5348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Mar 20, 2024
labkey-klum
approved these changes
Mar 20, 2024
- setting the sample type is independent of populating the columns
labkey-nicka
force-pushed
the
fb_material_interface
branch
from
a45da85 to
4246833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Initialization of the
ExpMaterialTableImplis inconsistent and makes it difficult to track how/what initialized the table. This updatesExpMaterialTableinterface to not includepopulate,setMaterialsnorsetSampleType. Setting materials in this way is not necessary and the single usage,ParentChildView, has been refactored to generate an IN clause as a base filter.Related Pull Requests
Changes
ExpSampleTypeis now done via the constructor and consistently initialized.ExpMaterialTableImpl.populateno longer takes anExpSampleTypeand initializes the sample type because it is done via construction.ExpMaterialTableImpl.setMaterialssetting materials in this way is not necessary and the single usage,ParentChildView, has been refactored to generate an IN clause as a base filter.ExpMaterialTableImplno longer accepts a name since we always want to initialize it to "Materials". Can still be set after initialization viasetName.