Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix FormHandlerAction for action that sends response in handlePost() #6368

Merged
merged 1 commit into from
Feb 25, 2025
Merged

fix FormHandlerAction for action that sends response in handlePost() #6368

merged 1 commit into from
Feb 25, 2025

Conversation

labkey-matthewb
Copy link
Contributor

Rationale

Issue 51755

Related Pull Requests

Changes

labkey-jeckels
labkey-jeckels approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this worth a comment somewhere in FormHandlerAction on how subclasses can support this pattern?

@labkey-matthewb
Copy link
Contributor Author

Is this worth a comment somewhere in FormHandlerAction on how subclasses can support this pattern?

Maybe? But there are other classes that seem a better fit. Like ExportAction

@labkey-matthewb labkey-matthewb merged commit 4c1d48d into develop Feb 25, 2025
6 checks passed
@labkey-matthewb labkey-matthewb deleted the fb_formhandler_51755 branch February 25, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-jeckels labkey-jeckels labkey-jeckels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-matthewb @labkey-jeckels