Issue 52400: IAE on SQL Server Inserting into a list with Auto Increment field with some names #6371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y Characters" fails with Illegal Argument exception on MSSQL
|
@labkey-matthewb let me know if you have an idea for a better way to handle this. |
Nope |
labkey-matthewb
approved these changes
Feb 25, 2025
| } | ||
| getStringBuilder().insert(index, sql.getRawSQL()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe check tempTokens.isEmpty() as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We should be using
SQLFragment.appendIdentifier()for add column names, and need to merge SQLFragments in selected cases.Changes
SQLFragment.insert(SQLFragment)for simple cases