Issue 52072: Text choice field values to handle | character within values #6374
+164
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g pipe character in validValues
…ns() and getTextChoiceValidatorExpression()
labkey-adam
reviewed
Feb 26, 2025
| String[] valueTokens = str.split("(?<!\\\\)" + escapedDelimiter); | ||
|
|
||
| // trim values and replace escaped delimiter | ||
| List<String> valueList = Arrays.stream(valueTokens).map(String::trim) |
There was a problem hiding this comment.
No need to go from list to stream to list to stream to list. Skip the toList() step on this line... keep it Stream<String> and then the steps below each become something simple like:
valueStream = valueStream.distinct();
valueStream = valueStream.sorted();
Then call .toList() on the return line.
There was a problem hiding this comment.
Prefect. That makes sense. Change made.
labkey-adam
requested changes
Feb 26, 2025
|
|
||
| values = PageFlowUtil.splitStringToValues("b|a|c| b | |", "|", false, false, false); | ||
| Assert.assertEquals(List.of("b", "a", "c", "b", ""), values); | ||
| } |
cnathe
added
TeamCity test review complete
and removed
needs TeamCity test review
labels
labkey-adam
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=52072
Text choice values are stored with a domain field as a regex validator as a concatenated string of values using the "|" delimiter. This PR updates this to account for values that contain the delimiter value.
Related Pull Requests
Changes