Apply no-op CSP filter to extra webapps #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Feb 22, 2024
Only standalone. Are you able to test embedded on 24.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Extra webapps are failing to load on standalone Tomcat when a CSP is configured in web.xml because
ContentSecurityPolicyFilteris not accessible at filter registration time (the class was moved to the webapp). https://www.labkey.org/home/Developer/issues/Secure/issues-details.view?issueId=49733Simplest solution (for now, to quickly unblock the labkey.org issue) is to throw a no-op filter with the same name into bootstrap. In my local testing, this gets applied to extra webapps whereas the "real" filter gets applied to the LabKey webapp.