Skip to content

Commit

Permalink
Add TODOs for code reuse
Browse files Browse the repository at this point in the history
  • Loading branch information
labkey-susanh committed Jan 24, 2025
1 parent 530f45f commit 3b0c9a2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/org/labkey/test/BaseWebDriverTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ public abstract class BaseWebDriverTest extends LabKeySiteWrapper implements Cle

public static final double DELTA = 10E-10;

// See QueryKey.ILLEGAL
// See QueryKey.ILLEGAL TODO make that array public so it can be used here
public static final String[] ILLEGAL_QUERY_KEY_CHARACTERS = {"$", "/", "&", "}", "~", ",", "."};
// See TSVWriter.shouldQuote. Generally we are not able to use the tab and new line characters when creating field names in the UI, but including here for completeness
public static final String[] TRICKY_IMPORT_FIELD_CHARACTERS = {"\\", "\"", "\\t", ",", "\\n", "\\r"};
Expand Down
1 change: 1 addition & 0 deletions src/org/labkey/test/TestFileUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,7 @@ public static File convertTabularToXlsx(File tabularFile, String delimiter, Stri
return excelFile;
}

// TODO should be able to use the methods in TSVWriter itself but currently has problems with NoClassDefFound
public static boolean shouldQuote(String value, String delimiter)
{
String escapeChars = _escapedCharsString + delimiter;
Expand Down

0 comments on commit 3b0c9a2

Please sign in to comment.