From b95c1506670353768d27827cfc4050a58d711faf Mon Sep 17 00:00:00 2001 From: labkey-nicka Date: Tue, 25 Feb 2025 13:10:38 -0800 Subject: [PATCH] KnitrReportTest: use checkExpectedErrors() instead of pause/resume JS error checks --- src/org/labkey/test/tests/KnitrReportTest.java | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/org/labkey/test/tests/KnitrReportTest.java b/src/org/labkey/test/tests/KnitrReportTest.java index 3b3ba0feb6..80708e982d 100644 --- a/src/org/labkey/test/tests/KnitrReportTest.java +++ b/src/org/labkey/test/tests/KnitrReportTest.java @@ -199,13 +199,10 @@ private void verifyAdhocReportDependencies(String viewName, String dependencies) createKnitrReport(rmdDependenciesReport, RReportHelper.ReportOption.knitrMarkdown); - pauseJsErrorChecker(); // Don't fail due to "$ is not a function" - { - _rReportHelper.clickReportTab(); - waitForElement(Locator.id("mtcars_table")); - assertElementNotPresent(Locator.id("mtcars_table_wrapper")); // Created by jQuery - } - resumeJsErrorChecker(); + _rReportHelper.clickReportTab(); + waitForElement(Locator.id("mtcars_table")); + assertElementNotPresent(Locator.id("mtcars_table_wrapper")); // Created by jQuery + checkExpectedErrors(1); // JavaScript error: "$(...).dataTable is not a function" // now set the dependencies _rReportHelper.clickSourceTab();