Skip to content

Commit

Permalink
Add test coverage for "Equals All Of" sample finder filter type (#1790)
Browse files Browse the repository at this point in the history
  • Loading branch information
XingY authored Jan 15, 2024
1 parent cd3264f commit c10b105
Showing 1 changed file with 21 additions and 14 deletions.
35 changes: 21 additions & 14 deletions src/org/labkey/test/components/ui/search/FilterExpressionPanel.java
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,16 @@ public WebDriver getDriver()
*/
public void setFilter(Expression expression)
{
setFilter(0, expression);
setFilter(0, expression._operator, expression._value1, expression._value2);
}

/**
* Set both filter expressions
*/
public void setFilters(Expression expression0, Expression expression1)
{
setFilter(0, expression0);
setFilter(1, expression1);
setFilter(0, expression0._operator, expression0._value1, expression0._value2);
setFilter(1, expression1._operator, expression1._value1, expression1._value2);
}

public void clearFilter()
Expand All @@ -74,12 +74,8 @@ public void clearFilter()
elementCache().filterTypeSelects.get(0).clearSelection();
}

private void setFilter(int index, Expression expression)
public void setFilter(int index, Object operator, Object value1, Object value2)
{
Operator operator = expression._operator;
Object value1 = expression._value1;
Object value2 = expression._value2;

setFilterType(index, operator);
if (value1 != null)
{
Expand Down Expand Up @@ -121,16 +117,27 @@ else if (value2 != null)
}
}

private void setFilterType(int index, Operator operator)
private void setFilterType(int index, Object op)
{
if (filterTypesLabelOverrides.containsKey(operator))
if (op instanceof Operator operator)
{
elementCache().filterTypeSelects.get(index).select(filterTypesLabelOverrides.get(operator));
if (filterTypesLabelOverrides.containsKey(operator))
{
elementCache().filterTypeSelects.get(index).select(filterTypesLabelOverrides.get(operator));
}
else
{
elementCache().filterTypeSelects.get(index).select(operator.getDisplayValue());
}
}
else
{
elementCache().filterTypeSelects.get(index).select(operator.getDisplayValue());
}
elementCache().filterTypeSelects.get(index).select(op.toString());

}

public boolean hasFilterType(int index, String filterCaption)
{
return elementCache().filterTypeSelects.get(index).getOptions().contains(filterCaption);
}

@Override
Expand Down

0 comments on commit c10b105

Please sign in to comment.