Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport test fixes from develop #1801

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

labkey-chrisj
Copy link
Contributor

@labkey-chrisj labkey-chrisj commented Jan 17, 2024

Rationale

Recently, the following tests failed in 23.11 in ways that have been addressed in develop

  • BiologicsBulkDataTest.bulkRegisterProtSequenceError
    • The 'cancel' button is not clickable, 'fade-modal' obscures it. In develop we wait for the button to be clickable in AppCreateDataClassesPage
  • BiologicsTest.testRegisterMoleculeMultipleProtein
    • The ComponentTag component took more than a second between name-click and render. In develop, we await for the staleness of the clicked component, for the AppMoleculeOverviewPage, and we give time to find the next ComponentTag
  • BiologicsAutoPopulateAssayJobSamplesTest.testAssociateTaskToExistingAssayRun
    • The DetailTableEdit cannot click 'save' because no edit occurred. This is likely because the call to clearSelectValue occurred before the selection appeared in the select, and when no selection is there, BaseReactSelect.clearSelectValue no-ops. In develop, the test can have DetailTableEdit wait for that value before clearing it
  • BiologicsSampleCreateTest.testDashboardCreateSamples
    • The EntityInsertPanel component assumes that if the grid isn't shown, it must be that the 'show grid' tab needs to be clicked. In develop, we first wait for either a tab or a grid to be present, and then act accordingly to reveal the grid if it isn't shown. (we also pull more operations into elementCache to force waitForReady to evaluate)

These changes seek to address test-noise failures in 23.11 by backporting changes from develop

Related Pull Requests

https://github.com/LabKey/biologics/pull/2654

prs as merged into develop
#1787 (DetailTableEdit- wait for selection before clearing)
https://github.com/LabKey/biologics/pull/2536 (ComponentTag- better syncing while verifying molecule components)
https://github.com/LabKey/biologics/pull/2576 (sync on form button staleness, multiple page classes)
#1718 (EntityInsertPanel- wait for panel before selecting grid)

Changes

  • backport changes to AppCreateDataClassesPage
  • backport changes to ComponentTag
  • backport waitForPage on AppMoleculeOverviewPage
  • backport DetailTableEdit changes
  • update test calls to DetailTableEdit.clearSelectValue
  • backport changes to EntityInsertPanel

Copy link

ERROR: A pull request from 23.11_fb_fixesFromDevelop is expected to target release23.11-SNAPSHOT, not develop

@labkey-chrisj labkey-chrisj changed the base branch from develop to release23.11-SNAPSHOT January 17, 2024 20:36
@labkey-chrisj labkey-chrisj merged commit 712f24d into release23.11-SNAPSHOT Jan 19, 2024
2 checks passed
@labkey-chrisj labkey-chrisj deleted the 23.11_fb_fixesFromDevelop branch January 19, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants