Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Recently, the following tests failed in 23.11 in ways that have been addressed in develop
AppCreateDataClassesPage
ComponentTag
component took more than a second between name-click and render. In develop, we await for the staleness of the clicked component, for theAppMoleculeOverviewPage
, and we give time to find the nextComponentTag
DetailTableEdit
cannot click 'save' because no edit occurred. This is likely because the call toclearSelectValue
occurred before the selection appeared in the select, and when no selection is there,BaseReactSelect.clearSelectValue
no-ops. In develop, the test can haveDetailTableEdit
wait for that value before clearing itEntityInsertPanel
component assumes that if the grid isn't shown, it must be that the 'show grid' tab needs to be clicked. In develop, we first wait for either a tab or a grid to be present, and then act accordingly to reveal the grid if it isn't shown. (we also pull more operations into elementCache to force waitForReady to evaluate)These changes seek to address test-noise failures in 23.11 by backporting changes from develop
Related Pull Requests
https://github.com/LabKey/biologics/pull/2654
prs as merged into develop
#1787 (
DetailTableEdit
- wait for selection before clearing)https://github.com/LabKey/biologics/pull/2536 (
ComponentTag
- better syncing while verifying molecule components)https://github.com/LabKey/biologics/pull/2576 (sync on form button staleness, multiple page classes)
#1718 (
EntityInsertPanel
- wait for panel before selecting grid)Changes
AppCreateDataClassesPage
ComponentTag
waitForPage
onAppMoleculeOverviewPage
DetailTableEdit
changesDetailTableEdit.clearSelectValue
EntityInsertPanel