wait for pager buttons to become clickable before clicking them #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
While debugging a failure in BiologicsReportTest.testReportSearchFilter, I realized that Pager.clickNext() does not ensure the next button is enabled before clicking
This means that unless tests are checking to see if it is, some could be (as testReportSearchFilter was) blindly clicking 'next' and assuming they were on the next page, but were still on the same page. This change should make that more strict
Related Pull Requests
https://github.com/LabKey/biologics/pull/2662
Changes
wait for next and prev to be enabled before clicking them