Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New helpers encodeUriPath() and decodeUriPath() #2226

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

labkey-adam
Copy link
Contributor

Rationale

The Jetty utils dependency is used only for encoding and decoding URL paths. We can likely use other existing libraries for these purposes and eliminate this dependency.

Introduce helper methods and route all callers to them. These methods can be updated to test and migrate to new implementations.

Copy link
Member

@labkey-tchad labkey-tchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with centralizing this but I have been unable to find any other library that clearly distinguishes between the path and query encoding/decoding.
Other methods tend to implement www-form-urlencoded which causes some wonkiness when you have a path containing '+' and ' '

@labkey-adam
Copy link
Contributor Author

I'm fine with centralizing this but I have been unable to find any other library that clearly distinguishes between the path and query encoding/decoding. Other methods tend to implement www-form-urlencoded which causes some wonkiness when you have a path containing '+' and ' '

Agreed... I was planning to do a quick replace with a standard method, but it's trickier than I expected, so I'm just bailing out and merging the centralization. Too many higher priority things going on.

@labkey-adam labkey-adam merged commit b71490f into develop Jan 20, 2025
4 checks passed
@labkey-adam labkey-adam deleted the fb_jetty branch January 20, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants