Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage for Issue 51382 #2291

Merged
merged 3 commits into from
Feb 25, 2025
Merged

coverage for Issue 51382 #2291

merged 3 commits into from
Feb 25, 2025

Conversation

labkey-chrisj
Copy link
Contributor

@labkey-chrisj labkey-chrisj commented Feb 21, 2025

Rationale

This change adds regression coverage for Issue 51382, Wikis unable to be accessed/deleted due to bad characters

The issue can't be repro'd via the UI, so this uses post commands to cover the create/update scenarios.

It also cleans up tests failing on TC-- AssayTransformImportUpdateTest was failing because the test disabled transform settings prior to checking their measures; the test now enables those measures before checking them

and, AssayTransformWarningTest was failing because the asserts expected the wrong file to have caused errors

Related Pull Requests

n/a

Changes

adds 2 test methods

@labkey-chrisj
Copy link
Contributor Author

labkey-chrisj commented Feb 21, 2025

@RosalineP One curious behavior I observed when writing the update case here: if I used a new command instance to do the update, the action never went into the updateWiki method -- (it checks for 'form.isNew'' on line 2204 of WikiController) and falls into the insertWiki case. 'isNew' appears to only check to see if entityId is null. (this is curious because setting the same json in different command objects seems to behave differently somehow)
This might just be a thing actual users will never encounter, but I thought it was worth calling out

@RosalineP
Copy link
Contributor

@RosalineP One curious behavior I observed when writing the update case here: if I used a new command instance to do the update, the action never went into the updateWiki method -- (it checks for 'form.isNew'' on line 2204 of WikiController) and falls into the insertWiki case. 'isNew' appears to only check to see if entityId is null. (this is curious because setting the same json in different command objects seems to behave differently somehow) This might just be a thing actual users will never encounter, but I thought it was worth calling out

Thanks for the heads up on this Chris! I agree this is weird but after a bit of poking around I'm not too concerned. Thank you for writing up this coverage!

@labkey-chrisj labkey-chrisj merged commit 0d4dbdf into develop Feb 25, 2025
4 checks passed
@labkey-chrisj labkey-chrisj deleted the fb_issue51382_test branch February 25, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants