Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume client-side error will always happen #2304

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Don't assume client-side error will always happen #2304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/org/labkey/test/tests/KnitrReportTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,13 @@ private void verifyAdhocReportDependencies(String viewName, String dependencies)
_rReportHelper.clickReportTab();
waitForElement(Locator.id("mtcars_table"));
assertElementNotPresent(Locator.id("mtcars_table_wrapper")); // Created by jQuery
Assertions.assertThat(getServerErrors()).as("Server errors").contains("$(...).dataTable is not a function");
checkExpectedErrors(1); // JavaScript error: "$(...).dataTable is not a function"
String serverErrors = getServerErrors();
if (!serverErrors.isEmpty())
{
// Client-side error doesn't always happen but, if it does, make sure it is the one we expect.
Assertions.assertThat(serverErrors).as("Server errors").contains("$(...).dataTable is not a function");
checkExpectedErrors(1); // JavaScript error: "$(...).dataTable is not a function"
}

// now set the dependencies
_rReportHelper.clickSourceTab();
Expand Down