Bugfix for construct

danijelk · web-flow · commit 06f7c6bd5a29 · 2020-11-12T14:39:48.000+01:00
Defaulting agreement to an empty string means that it will never load the config() as fallback
diff --git a/src/Economic.php b/src/Economic.php
@@ -43,7 +43,7 @@ class Economic
 
     protected $stripNullValues;
 
-    public function __construct($agreement = '', $apiSecret = null, $apiPublic = null, $stripNull = null)
+    public function __construct($agreement = null, $apiSecret = null, $apiPublic = null, $stripNull = null)
     {
         $this->agreement = $agreement ?? config('economic.agreement');
         $this->apiSecret = $apiSecret ?? config('economic.secret_token');

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ class Economic`
`43`	`43`
`44`	`44`	`protected $stripNullValues;`
`45`	`45`
`46`		`- public function __construct($agreement = '', $apiSecret = null, $apiPublic = null, $stripNull = null)`
	`46`	`+ public function __construct($agreement = null, $apiSecret = null, $apiPublic = null, $stripNull = null)`
`47`	`47`	`{`
`48`	`48`	`$this->agreement = $agreement ?? config('economic.agreement');`
`49`	`49`	`$this->apiSecret = $apiSecret ?? config('economic.secret_token');`