Skip to content

Commit 2dd12f6

Browse files
committed
Update Mac build signing
1 parent 777d8d5 commit 2dd12f6

File tree

2 files changed

+42
-8
lines changed

2 files changed

+42
-8
lines changed

.github/workflows/build.yml

+39-3
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,51 @@ jobs:
5252
if: matrix.os == 'macos-latest'
5353
run: |
5454
echo ${{ secrets.GODOT_MACOS_NOTARIZATION_API_KEY }} | base64 --decode > notarization_api_key.p8
55+
56+
# Create build directory and add entitlements file
57+
mkdir -p build
58+
cat > build/entitlements.mac.plist << 'EOL'
59+
<?xml version="1.0" encoding="UTF-8"?>
60+
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
61+
<plist version="1.0">
62+
<dict>
63+
<key>com.apple.security.cs.allow-jit</key>
64+
<true/>
65+
<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
66+
<true/>
67+
<key>com.apple.security.cs.allow-dyld-environment-variables</key>
68+
<true/>
69+
<key>com.apple.security.cs.disable-library-validation</key>
70+
<true/>
71+
<key>com.apple.security.inherit</key>
72+
<true/>
73+
<key>com.apple.security.automation.apple-events</key>
74+
<true/>
75+
</dict>
76+
</plist>
77+
EOL
5578
56-
- name: Build Electron app
57-
if: matrix.os != 'ubuntu-latest-large'
79+
- name: Build Electron app (macOS)
80+
if: matrix.os == 'macos-latest'
5881
env:
5982
DEBUG: electron-builder
6083
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6184
APPLE_API_KEY: ${{ secrets.GODOT_MACOS_NOTARIZATION_API_KEY }}
6285
APPLE_API_KEY_ID: ${{ secrets.GODOT_MACOS_NOTARIZATION_API_KEY_ID }}
63-
APPLE_API_KEY_ISSUER: ${{ secrets.GODOT_MACOS_NOTARIZATION_API_UUID }}
86+
APPLE_API_ISSUER: ${{ secrets.GODOT_MACOS_NOTARIZATION_API_UUID }}
87+
run: |
88+
# Debug: Verify environment variables are set (without exposing values)
89+
if [ -n "$APPLE_API_KEY" ]; then echo "APPLE_API_KEY is set"; else echo "APPLE_API_KEY is NOT set"; fi
90+
if [ -n "$APPLE_API_KEY_ID" ]; then echo "APPLE_API_KEY_ID is set"; else echo "APPLE_API_KEY_ID is NOT set"; fi
91+
if [ -n "$APPLE_API_ISSUER" ]; then echo "APPLE_API_ISSUER is set"; else echo "APPLE_API_ISSUER is NOT set"; fi
92+
93+
npm run electron-build
94+
95+
- name: Build Electron app (Windows)
96+
if: matrix.os == 'windows-latest'
97+
env:
98+
DEBUG: electron-builder
99+
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
64100
run: npm run electron-build
65101

66102
- name: Build Electron app (Linux)

package.json

+3-5
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,9 @@
145145
"icon": "public/icon.icns",
146146
"hardenedRuntime": true,
147147
"gatekeeperAssess": false,
148-
"entitlements": "build/entitlements.mac.plist",
149-
"entitlementsInherit": "build/entitlements.mac.plist",
150-
"notarize": {
151-
"teamId": "APPLE_TEAM_ID"
152-
}
148+
"entitlements": "./build/entitlements.mac.plist",
149+
"entitlementsInherit": "./build/entitlements.mac.plist",
150+
"notarize": true
153151
}
154152
},
155153
"devDependencies": {

0 commit comments

Comments
 (0)