-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed single quote error #47
Open
maxwilkinsontech
wants to merge
19
commits into
LeeHanYeong:master
Choose a base branch
from
maxwilkinsontech:escape-template
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixed single quote error #47
maxwilkinsontech
wants to merge
19
commits into
LeeHanYeong:master
from
maxwilkinsontech:escape-template
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix content damage on validation error * Fix fixtures format and enable null values * Fixed non-saving data of dynamically created quills * Poetry fix * Setup fix Co-authored-by: Michał Dyczko <michal.dyczko@poczta.pl>
Update widgets.py
this allows the db backend to apply any optimizations it might want/need closes LeeHanYeong#26 Co-authored-by: proxi <51172302+3n-k1@users.noreply.github.com>
* Bump to Quill Version 1.3.7 Bump to Quill Version 1.3.7 - This version of Quill fixes Quill Vuln slab/quill#2438 Here is the change commit to fix the vuln in Quill slab/quill#2439 The Vuln is described here: https://ossindex.sonatype.org/vuln/d96c07dd-81f9-41f6-b2bd-531143bcaeab * Adding JS/CSS include instructions from README.md Resolves issue [LeeHanYeong#33](LeeHanYeong#33)
…ttribute 'json_string' (LeeHanYeong#41) * Bump to Quill Version 1.3.7 Bump to Quill Version 1.3.7 - This version of Quill fixes Quill Vuln slab/quill#2438 Here is the change commit to fix the vuln in Quill slab/quill#2439 The Vuln is described here: https://ossindex.sonatype.org/vuln/d96c07dd-81f9-41f6-b2bd-531143bcaeab * Adding JS/CSS include instructions from README.md Resolves issue [LeeHanYeong#33](LeeHanYeong#33) * adding None return for json_string
258ba27
to
26049ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When the field content contains a single quote, I get the error:
This is due to the
value
widget template variable not being escaped and causing situations like:which is causing the error above.
When this error occurs, the quilljs widget does not render at all.
Adding the
escape
filter to thedangerouslyPasteHTML
function argument seems to fix this bug.Cheers.