Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry sync v2 - Block #172

Merged
merged 8 commits into from
Feb 11, 2025
Merged

Registry sync v2 - Block #172

merged 8 commits into from
Feb 11, 2025
+893 −1

Conversation

thecatcore
Copy link
Member

@thecatcore thecatcore commented May 8, 2024 •
edited
Loading

Depends on #168

What does this module do:

  • Register vanilla Block registry into Registry sync v2 system
  • Set block translation key from identifier when registering it
  • For 1.8+, link BlockItem to its Block.
  • For 1.8+, register blockstates when block is registered.
  • For 1.8+, remap blockstates ids after blocks are remapped.
  • [NEW] Set whether a modded block should use neighbouring block's light or not
  • [NEW] For 1.7.10, fix Block to Item and Item to Block conversion, previously preventing picking up modded in creative mode. This should also fix recipes not working correctly and other related issues.

@thecatcore thecatcore mentioned this pull request May 8, 2024
Merged
@thecatcore thecatcore self-assigned this May 9, 2024
@thecatcore thecatcore added enhancement New feature or request new module New module bikeshed yes draft labels May 9, 2024
@thecatcore thecatcore added this to the 1.11.0 milestone Aug 29, 2024
@thecatcore thecatcore force-pushed the feature/registry-sync-v2/block branch from caa63a6 to d66cda2 Compare December 22, 2024 16:37
@thecatcore thecatcore modified the milestones: 1.11.0, 1.12.0 Jan 31, 2025
@thecatcore thecatcore force-pushed the feature/registry-sync-v2/block branch from 9da83b0 to 60b1441 Compare February 10, 2025 22:02
@thecatcore thecatcore marked this pull request as ready for review February 10, 2025 22:05
@thecatcore thecatcore removed the draft label Feb 10, 2025
@thecatcore thecatcore merged commit c89b8a8 into Legacy-Fabric:feature/registry-sync-v2/main Feb 11, 2025
2 checks passed
thecatcore added a commit that referenced this pull request Feb 27, 2025
@thecatcore
Registry sync v2 - Block (#172)
1b14d7e 
* Block module rebase fixes

* Fix whether to use neighbour light for Modded blocks

* Clean up and fix style

* Update test mods

* Fix compiling errors

* Spotless

* Fix compiling errors

* PR Feedback
@thecatcore thecatcore deleted the feature/registry-sync-v2/block branch February 27, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ENDERZOMBI102 ENDERZOMBI102 ENDERZOMBI102 approved these changes

Assignees

@thecatcore thecatcore

Labels
bikeshed yes enhancement New feature or request new module New module
Projects
Legacy Fabric API
Status: Done
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thecatcore @ENDERZOMBI102