Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update transactions page to use global ledger selector #166

Merged
merged 1 commit into from
Feb 21, 2025
Merged

feat: update transactions page to use global ledger selector #166

merged 1 commit into from
Feb 21, 2025

Conversation

gabrielcastr0
Copy link
Member

Midaz Console Pull Request Checklist

  • Remove LedgerPanel UI
  • Remove local ledger selector and associated state
  • Fix Transactions Stepper error

Pull Request Type

  • UI
  • Core (Business Logic)
  • Security
  • internationalization
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

@gabrielcastr0 gabrielcastr0 self-assigned this Feb 20, 2025
@gabrielcastr0 gabrielcastr0 merged commit caabf04 into develop Feb 21, 2025
4 of 7 checks passed
@gabrielcastr0 gabrielcastr0 deleted the feature/transactions-global-ledger branch February 21, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpmpb tpmpb tpmpb approved these changes

@caioaletroca caioaletroca caioaletroca approved these changes

@augusto-draxx augusto-draxx Awaiting requested review from augusto-draxx

Assignees

@gabrielcastr0 gabrielcastr0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielcastr0 @tpmpb @caioaletroca