Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/accounts and portfolios #70

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Conversation

gabrielcastr0
Copy link
Member

Midaz Console Pull Request Checklist

  • Implements the functionality to fetch accounts along with their associated portfolios, including accounts without portfolios and vice versa.
  • Updates the optional and required fields in the create accounts payload.

Pull Request Type

  • UI
  • Core (Business Lógic)
  • Security
  • internationalization
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

@gabrielcastr0 gabrielcastr0 requested a review from tpmpb December 3, 2024 22:49
@caioaletroca
Copy link
Contributor

@gabrielcastr0 I noticed that intl keys changed but there isn't any translation files changes.
Please run the extract, and using this opportunity, run test, lint and build too to check if everything is fine.

Copy link
Contributor

@caioaletroca caioaletroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that overhaul!!!

@gabrielcastr0 gabrielcastr0 merged commit afe3a3a into develop Dec 4, 2024
5 checks passed
@gabrielcastr0 gabrielcastr0 deleted the feat/accounts-and-portfolios branch December 4, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants