Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/MIDAZ-454 #454

Closed
wants to merge 17 commits into from
Closed

Conversation

maxwelbm
Copy link
Contributor

@maxwelbm maxwelbm commented Jan 8, 2025

Midaz Pull Request Checklist

Pull Request Type

  • Auth
  • Infra
  • Ledger
  • Mdz
  • Transaction
  • Audit
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

@maxwelbm maxwelbm added the don't merge Don't merge this PR label Jan 8, 2025
@maxwelbm maxwelbm self-assigned this Jan 8, 2025
@maxwelbm maxwelbm requested a review from a team as a code owner January 8, 2025 13:45
Copy link

what-the-diff bot commented Jan 8, 2025

PR Summary

  • Switched Workflow Trigger Event
    The workflow will now be set off when a pull request is made, rather than when a new release is published. This should help with catching and addressing issues earlier in the process.

  • Implemented Branch Filtering
    The system has been updated to specifically look at pull requests aimed at the 'develop' and 'main' branches. This change will make sure the system focuses on the most critical branches.

  • Expanded Pull Request Event Types
    The system will now react to more types of events in pull requests, including when they're opened, edited, synchronized, or reopened. This increased responsiveness means that changes and updates should be handled more efficiently.

  • Added Console Output for Checksum
    When executing, the system will now output the checksum to the console. This will give immediate, visible feedback about the status of operations.

  • Disabled Chocolatey API Key Upload
    For the moment, code related to adding an API key and uploading packages to software management platform Chocolatey has been commented out, effectively disabling it. This action may be related to maintaining system security or re-evaluating package deployment processes.

@MartinezAvellan MartinezAvellan changed the title Feature: search account for alias or ID Feature/MIDAZ-454 Jan 8, 2025
@maxwelbm maxwelbm closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge Don't merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants