update

Author: deependujha

tests/processing/test_utilities.py

@@ -72,7 +72,7 @@ def test_extract_rank_and_index_from_filename():
         assert index == rank_and_index[idx][1]
 
 
-def test_read_index_file_content(tmpdir):
+def test_read_index_file_content(tmpdir, monkeypatch):
     output_dir = tmpdir / "output_dir"
 
     assert read_index_file_content(_resolve_dir(str(output_dir))) is None
@@ -86,6 +86,16 @@ def test_read_index_file_content(tmpdir):
 
     assert read_index_file_content(_resolve_dir(str(output_dir))) == dummy_dict
 
+    def _fn(remote_path, local_path):
+        with open(local_path, "w") as f:
+            json.dump(dummy_dict, f)
+
+    fs_provider = MagicMock()
+    fs_provider.download_file = _fn
+
+    monkeypatch.setattr(utilities_module, "_get_fs_provider", MagicMock(return_value=fs_provider))
+    assert read_index_file_content(_resolve_dir("s3://bucket/path")) == dummy_dict
+
 
 def test_remove_uuid_from_filename():
     filepaths = [

tests/streaming/test_resolver.py

@@ -359,6 +359,17 @@ def test_assert_dir_has_index_file(monkeypatch):
 
     resolver._assert_dir_has_index_file(resolver.Dir(path="/teamspace/...", url="s3://"))
 
+    fs_provider.exists = mock.MagicMock(return_value=True)
+
+    fs_provider.is_empty = mock.MagicMock(return_value=False)
+    fs_provider.delete_file_or_directory = mock.MagicMock()
+
+    resolver._assert_dir_has_index_file(resolver.Dir(path="/teamspace/...", url="s3://"), mode="overwrite")
+
+    resolver._assert_dir_has_index_file(resolver.Dir(path="/teamspace/...", url="s3://"), mode="append")
+
+    assert fs_provider.delete_file_or_directory.call_count == 1
+
 
 def test_resolve_dir_absolute(tmp_path, monkeypatch):
     """Test that the directory gets resolved to an absolute path and symlinks are followed."""