Skip to content

Commit 64d0d02

Browse files
LukasSalchowLukas Salchowlantigapre-commit-ci[bot]
authored
Fix TypeError in configure_optimizers when running with ReduceLROnPlateau (#20471)
* fix TypeError in configure_optimizers * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Lukas Salchow <sachowlukas@gmail.com> Co-authored-by: Luca Antiga <luca.antiga@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 6b88ddc commit 64d0d02

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

src/lightning/pytorch/utilities/types.py

+11-4
Original file line numberDiff line numberDiff line change
@@ -104,18 +104,25 @@ class LRSchedulerConfigType(TypedDict, total=False):
104104
strict: bool
105105

106106

107-
class OptimizerLRSchedulerConfig(TypedDict):
107+
class OptimizerConfigDict(TypedDict):
108108
optimizer: Optimizer
109-
lr_scheduler: NotRequired[Union[LRSchedulerTypeUnion, LRSchedulerConfigType]]
109+
110+
111+
class OptimizerLRSchedulerConfigDict(TypedDict):
112+
optimizer: Optimizer
113+
lr_scheduler: Union[LRSchedulerTypeUnion, LRSchedulerConfigType]
114+
monitor: NotRequired[str]
110115

111116

112117
OptimizerLRScheduler = Optional[
113118
Union[
114119
Optimizer,
115120
Sequence[Optimizer],
116121
tuple[Sequence[Optimizer], Sequence[Union[LRSchedulerTypeUnion, LRSchedulerConfig]]],
117-
OptimizerLRSchedulerConfig,
118-
Sequence[OptimizerLRSchedulerConfig],
122+
OptimizerConfigDict,
123+
OptimizerLRSchedulerConfigDict,
124+
Sequence[OptimizerConfigDict],
125+
Sequence[OptimizerLRSchedulerConfigDict],
119126
]
120127
]
121128

0 commit comments

Comments
 (0)