Skip to content

Commit 7b19eb7

Browse files
authored
Apply suggestions from code review
1 parent a12a1ec commit 7b19eb7

File tree

4 files changed

+2
-4
lines changed

4 files changed

+2
-4
lines changed

.azure/gpu-tests-fabric.yml

-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ jobs:
4949
FREEZE_REQUIREMENTS: "1"
5050
PIP_CACHE_DIR: "/var/tmp/pip"
5151
PL_RUN_CUDA_TESTS: "1"
52-
PL_STANDALONE_TESTS_BATCH_SIZE: "1" # todo
5352
container:
5453
image: $(image)
5554
# default shm size is 64m. Increase it to avoid:

.azure/gpu-tests-pytorch.yml

-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ jobs:
6464
FREEZE_REQUIREMENTS: "1"
6565
PIP_CACHE_DIR: "/var/tmp/pip"
6666
PL_RUN_CUDA_TESTS: "1"
67-
PL_STANDALONE_TESTS_BATCH_SIZE: "2" # todo
6867
container:
6968
image: $(image)
7069
# default shm size is 64m. Increase it to avoid:

tests/tests_fabric/plugins/precision/test_bitsandbytes.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
from tests_fabric.helpers.runif import RunIf
2828

2929

30-
@pytest.mark.skipif(not _BITSANDBYTES_AVAILABLE, reason="bitsandbytes needs to be unavailable")
30+
@pytest.mark.skipif(_BITSANDBYTES_AVAILABLE, reason="bitsandbytes needs to be unavailable")
3131
def test_bitsandbytes_plugin(monkeypatch):
3232
module = lightning.fabric.plugins.precision.bitsandbytes
3333
monkeypatch.setattr(module, "_BITSANDBYTES_AVAILABLE", lambda: True)

tests/tests_pytorch/plugins/precision/test_bitsandbytes.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from lightning.pytorch.plugins.precision.bitsandbytes import BitsandbytesPrecision
2525

2626

27-
@pytest.mark.skipif(not _BITSANDBYTES_AVAILABLE, reason="bitsandbytes needs to be unavailable")
27+
@pytest.mark.skipif(_BITSANDBYTES_AVAILABLE, reason="bitsandbytes needs to be unavailable")
2828
def test_bitsandbytes_plugin(monkeypatch):
2929
module = lightning.fabric.plugins.precision.bitsandbytes
3030
monkeypatch.setattr(module, "_BITSANDBYTES_AVAILABLE", lambda: True)

0 commit comments

Comments
 (0)