Fix infinite recursion error in precision plugin graveyard (#19542)

Author: awaelchli

src/lightning/pytorch/CHANGELOG.md

@@ -51,7 +51,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Fixed support for Remote Stop and Remote Abort with NeptuneLogger ([#19130](https://github.com/Lightning-AI/pytorch-lightning/pull/19130))
 
 
--
+- Fixed infinite recursion error in precision plugin graveyard ([#19542](https://github.com/Lightning-AI/pytorch-lightning/pull/19542))
+
 
 
 ## [2.2.0] - 2024-02-08

src/lightning/pytorch/_graveyard/precision.py

@@ -50,7 +50,7 @@ def init(self: type, *args: Any, **kwargs: Any) -> None:
             f"The `{deprecated_name}` is deprecated."
             f" Use `lightning.pytorch.plugins.precision.{new_class.__name__}` instead."
         )
-        super(type(self), self).__init__(*args, **kwargs)
+        new_class.__init__(self, *args, **kwargs)  # type: ignore[misc]
 
     return type(deprecated_name, (new_class,), {"__init__": init})
 

tests/tests_pytorch/graveyard/test_precision.py

@@ -1,3 +1,6 @@
+import pytest
+
+
 def test_precision_plugin_renamed_imports():
     # base class
     from lightning.pytorch.plugins import PrecisionPlugin as PrecisionPlugin2
@@ -9,6 +12,10 @@ def test_precision_plugin_renamed_imports():
     assert issubclass(PrecisionPlugin1, Precision)
     assert issubclass(PrecisionPlugin2, Precision)
 
+    for plugin_cls in [PrecisionPlugin0, PrecisionPlugin1, PrecisionPlugin2]:
+        with pytest.warns(DeprecationWarning, match="The `PrecisionPlugin` is deprecated"):
+            plugin_cls()
+
     # bitsandbytes
     from lightning.pytorch.plugins import BitsandbytesPrecisionPlugin as BnbPlugin2
     from lightning.pytorch.plugins.precision import BitsandbytesPrecisionPlugin as BnbPlugin1
@@ -39,6 +46,10 @@ def test_precision_plugin_renamed_imports():
     assert issubclass(DoublePlugin1, DoublePrecision)
     assert issubclass(DoublePlugin2, DoublePrecision)
 
+    for plugin_cls in [DoublePlugin0, DoublePlugin1, DoublePlugin2]:
+        with pytest.warns(DeprecationWarning, match="The `DoublePrecisionPlugin` is deprecated"):
+            plugin_cls()
+
     # fsdp
     from lightning.pytorch.plugins import FSDPPrecisionPlugin as FSDPPlugin2
     from lightning.pytorch.plugins.precision import FSDPPrecisionPlugin as FSDPPlugin1
@@ -49,6 +60,10 @@ def test_precision_plugin_renamed_imports():
     assert issubclass(FSDPPlugin1, FSDPPrecision)
     assert issubclass(FSDPPlugin2, FSDPPrecision)
 
+    for plugin_cls in [FSDPPlugin0, FSDPPlugin1, FSDPPlugin2]:
+        with pytest.warns(DeprecationWarning, match="The `FSDPPrecisionPlugin` is deprecated"):
+            plugin_cls(precision="16-mixed")
+
     # half
     from lightning.pytorch.plugins import HalfPrecisionPlugin as HalfPlugin2
     from lightning.pytorch.plugins.precision import HalfPrecisionPlugin as HalfPlugin1
@@ -59,6 +74,10 @@ def test_precision_plugin_renamed_imports():
     assert issubclass(HalfPlugin1, HalfPrecision)
     assert issubclass(HalfPlugin2, HalfPrecision)
 
+    for plugin_cls in [HalfPlugin0, HalfPlugin1, HalfPlugin2]:
+        with pytest.warns(DeprecationWarning, match="The `HalfPrecisionPlugin` is deprecated"):
+            plugin_cls()
+
     # mixed
     from lightning.pytorch.plugins import MixedPrecisionPlugin as MixedPlugin2
     from lightning.pytorch.plugins.precision import MixedPrecisionPlugin as MixedPlugin1
@@ -69,6 +88,10 @@ def test_precision_plugin_renamed_imports():
     assert issubclass(MixedPlugin1, MixedPrecision)
     assert issubclass(MixedPlugin2, MixedPrecision)
 
+    for plugin_cls in [MixedPlugin0, MixedPlugin1, MixedPlugin2]:
+        with pytest.warns(DeprecationWarning, match="The `MixedPrecisionPlugin` is deprecated"):
+            plugin_cls(precision="bf16-mixed", device="cuda:0")
+
     # transformer_engine
     from lightning.pytorch.plugins import TransformerEnginePrecisionPlugin as TEPlugin2
     from lightning.pytorch.plugins.precision import TransformerEnginePrecisionPlugin as TEPlugin1