Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shortcut name for DeepSpeed stage 1 offload #19075

Conversation

nik777
Copy link
Contributor

@nik777 nik777 commented Nov 28, 2023

What does this PR do?

Fixes #17638

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • [ x] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19075.org.readthedocs.build/en/19075/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Nov 28, 2023
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 28, 2023
@nik777 nik777 marked this pull request as ready for review November 28, 2023 05:20
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #19075 (ee55ca8) into master (9624aae) will decrease coverage by 30%.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19075      +/-   ##
==========================================
- Coverage      83%      54%     -30%     
==========================================
  Files         450      445       -5     
  Lines       38036    37939      -97     
==========================================
- Hits        31717    20315   -11402     
- Misses       6319    17624   +11305     

Copy link

gitguardian bot commented Jan 16, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@mergify mergify bot added the has conflicts label Feb 1, 2024
@awaelchli awaelchli changed the title Feature/17638 support deepspeed stage 1 offload Support shortcut name for DeepSpeed stage 1 offload Feb 5, 2024
@awaelchli awaelchli added feature Is an improvement or enhancement strategy: deepspeed labels Feb 5, 2024
@mergify mergify bot removed the has conflicts label Feb 5, 2024
@awaelchli awaelchli added the community This PR is from the community label Feb 5, 2024
@mergify mergify bot added the ready PRs ready to be merged label Feb 5, 2024
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Feb 6, 2024
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Feb 6, 2024
@mergify mergify bot added ready PRs ready to be merged and removed ready PRs ready to be merged labels Feb 6, 2024
@awaelchli awaelchli merged commit 7a56ac5 into Lightning-AI:master Feb 6, 2024
115 of 116 checks passed
@awaelchli awaelchli added this to the 2.2 milestone Feb 6, 2024
@nik777 nik777 deleted the feature/17638_support_deepspeed_stage_1_offload branch February 6, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community fabric lightning.fabric.Fabric feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: deepspeed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support strategy="deepspeed_stage_1_offload"
3 participants