-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_restricted_classmethod
: add wrapper, to allow inspection
#19332
Merged
awaelchli
merged 6 commits into
Lightning-AI:master
from
lauritsf:bugfix/restricted-method-inspect-issue
Jan 23, 2024
Merged
_restricted_classmethod
: add wrapper, to allow inspection
#19332
awaelchli
merged 6 commits into
Lightning-AI:master
from
lauritsf:bugfix/restricted-method-inspect-issue
Jan 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19332 +/- ##
==========================================
- Coverage 84% 49% -35%
==========================================
Files 446 438 -8
Lines 37570 37418 -152
==========================================
- Hits 31383 18292 -13091
- Misses 6187 19126 +12939 |
awaelchli
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for the quick fix. Would you mind adding a line in src/lightning/pytorch/CHANGELOG.md
as well?
2fb1795
to
872bee3
Compare
872bee3
to
498d35f
Compare
awaelchli
reviewed
Jan 23, 2024
_restricted_classmethod
: add wrapper, to allow inspection
Borda
approved these changes
Jan 23, 2024
awaelchli
added a commit
that referenced
this pull request
Jan 30, 2024
lexierule
pushed a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves an issue where using
inspect.getmembers
on aLightningModule
instance (or any class using_restricted_classmethod_impl
) would incorrectly raise aTypeError
. The modification introduces a wrapper in the_restricted_classmethod_impl
to ensure that the method can be inspected but not called on an instance. This change maintains the intended functionality while improving compatibility with introspection tools likeinspect.getmembers
.Fixes #19329
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19332.org.readthedocs.build/en/19332/