Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link in Fabric #19417

Closed
wants to merge 1 commit into from
Closed

docs: fix broken link in Fabric #19417

wants to merge 1 commit into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 6, 2024

What does this PR do?

Addressing broken link https://github.com/Lightning-AI/pytorch-lightning/actions/runs/7793545800/job/21253447285

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19417.org.readthedocs.build/en/19417/

cc @Borda @carmocca @justusschock @awaelchli

@Borda Borda requested a review from carmocca February 6, 2024 09:43
@github-actions github-actions bot added docs Documentation related fabric lightning.fabric.Fabric labels Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to docs/source-fabric/advanced/compile.rst.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda
Copy link
Member Author

Borda commented Feb 6, 2024

closing in favor of #19387

@Borda Borda closed this Feb 6, 2024
@Borda Borda added the duplicate This issue or pull request already exists label Feb 6, 2024
@Borda Borda deleted the docs/fabric-link branch July 26, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related duplicate This issue or pull request already exists fabric lightning.fabric.Fabric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant