Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: drop chlog for data #19422

Merged
merged 1 commit into from
Feb 6, 2024
Merged

docs: drop chlog for data #19422

merged 1 commit into from
Feb 6, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 6, 2024

What does this PR do?

implication of #19420 (comment)

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19422.org.readthedocs.build/en/19422/

@Borda Borda requested a review from tchaton as a code owner February 6, 2024 12:53
@github-actions github-actions bot added the data (external) litdata package label Feb 6, 2024
@Borda Borda mentioned this pull request Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda requested review from awaelchli and carmocca February 6, 2024 12:53
@Borda Borda changed the base branch from master to release-2.2.0-final February 6, 2024 13:07
@Borda Borda merged commit eccb428 into release-2.2.0-final Feb 6, 2024
13 checks passed
@Borda Borda deleted the docs/drop-data-chlog branch February 6, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data (external) litdata package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant