bump: testing with latest `torch` 2.6 #20509

Borda · 2024-12-19T17:17:40Z

What does this PR do?

early visibility for potential breaking changes with next PT release

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20509.org.readthedocs.build/en/20509/

cc @Borda @lantiga @justusschock

github-actions · 2024-12-19T17:18:10Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu-guardian	success	✅

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, requirements/fabric/base.txt, requirements/fabric/strategies.txt, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/utilities/imports.py, requirements/pytorch/base.txt, requirements/pytorch/extra.txt, tests/tests_pytorch/conftest.py, tests/tests_pytorch/models/test_onnx.py, tests/tests_pytorch/plugins/precision/test_bitsandbytes.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs) (testing Lightning \| latest)	success	✅
pytorch-lightning (GPUs) (testing PyTorch \| latest)	success	✅

These checks are required after the changes to .azure/gpu-tests-pytorch.yml, requirements/pytorch/base.txt, requirements/pytorch/extra.txt, tests/tests_pytorch/conftest.py, tests/tests_pytorch/models/test_onnx.py, tests/tests_pytorch/plugins/precision/test_bitsandbytes.py, tests/run_standalone_tests.sh, requirements/fabric/base.txt, requirements/fabric/strategies.txt, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/utilities/imports.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/strategies.txt, requirements/pytorch/base.txt, requirements/pytorch/extra.txt, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/utilities/imports.py.

🟢 fabric: Docs

Check ID	Status
docs-make (fabric, doctest)	success	✅
docs-make (fabric, html)	success	✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/utilities/imports.py, .github/workflows/docs-build.yml, requirements/fabric/base.txt, requirements/fabric/strategies.txt.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-make (pytorch, doctest)	success	✅
docs-make (pytorch, html)	success	✅

These checks are required after the changes to .github/workflows/docs-build.yml, requirements/pytorch/base.txt, requirements/pytorch/extra.txt.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.10, 2.1.2, 12.1.1)	success	✅
build-cuda (3.11, 2.2.2, 12.1.1)	success	✅
build-cuda (3.11, 2.3.1, 12.1.1)	success	✅
build-cuda (3.11, 2.4.1, 12.1.1)	success	✅
build-cuda (3.12, 2.5.1, 12.1.1)	success	✅
build-pl (3.10, 2.1, 12.1.1)	success	✅
build-pl (3.11, 2.2, 12.1.1)	success	✅
build-pl (3.11, 2.3, 12.1.1)	success	✅
build-pl (3.11, 2.4, 12.1.1)	success	✅
build-pl (3.12, 2.5, 12.1.1, true)	success	✅

These checks are required after the changes to .github/workflows/docker-build.yml, dockers/base-cuda/Dockerfile, requirements/pytorch/base.txt, requirements/pytorch/extra.txt, requirements/fabric/base.txt, requirements/fabric/strategies.txt.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu-guardian	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/strategies.txt, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/utilities/imports.py, tests/tests_fabric/plugins/precision/test_bitsandbytes.py, tests/tests_fabric/strategies/test_ddp_integration.py, tests/tests_fabric/strategies/test_fsdp_integration.py, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs) (testing Fabric \| latest)	success	✅
lightning-fabric (GPUs) (testing Lightning \| latest)	success	✅

These checks are required after the changes to .azure/gpu-tests-fabric.yml, requirements/fabric/base.txt, requirements/fabric/strategies.txt, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/utilities/imports.py, tests/tests_fabric/plugins/precision/test_bitsandbytes.py, tests/tests_fabric/strategies/test_ddp_integration.py, tests/tests_fabric/strategies/test_fsdp_integration.py, tests/run_standalone_tests.sh.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/strategies.txt, requirements/pytorch/base.txt, requirements/pytorch/extra.txt, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/utilities/imports.py.

🟢 install

Check ID	Status
install-pkg-guardian	success	✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/utilities/imports.py, requirements/fabric/base.txt, requirements/fabric/strategies.txt, requirements/pytorch/base.txt, requirements/pytorch/extra.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

codecov · 2024-12-19T17:27:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88%. Comparing base (02e2668) to head (eac0f94).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #20509   +/-   ##
=======================================
- Coverage      88%      88%   -0%     
=======================================
  Files         267      267           
  Lines       23372    23373    +1     
=======================================
  Hits        20483    20483           
- Misses       2889     2890    +1

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

for more information, see https://pre-commit.ci

…tning into ci/bump-pt-2.6

for more information, see https://pre-commit.ci

…tning into ci/bump-pt-2.6

Borda · 2025-03-11T08:59:08Z

hitting bitsandbytes-foundation/bitsandbytes#1492

.azure/gpu-tests-fabric.yml

.azure/gpu-tests-pytorch.yml

tests/tests_fabric/plugins/precision/test_bitsandbytes.py

tests/tests_pytorch/plugins/precision/test_bitsandbytes.py

lantiga

Fantastic job @Borda

t-vi

Looks good, thank you @Borda

Borda · 2025-03-11T13:02:56Z

updating the required checks in #20635

* bump: testing with future torch 2.6 * bump `typing-extensions` * TORCHINDUCTOR_CACHE_DIR * bitsandbytes * Apply suggestions from code review * _TORCH_LESS_EQUAL_2_6 --------- Co-authored-by: Luca Antiga <luca.antiga@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Luca Antiga <luca@lightning.ai> (cherry picked from commit a0134d2)

bump: testing with future torch 2.6

2bdc588

Borda requested review from lantiga, tchaton, justusschock and ethanwharris as code owners December 19, 2024 17:17

github-actions bot added ci Continuous Integration dockers labels Dec 19, 2024

bump typing-extensions

89153f0

github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Dec 19, 2024

lantiga and others added 7 commits January 6, 2025 11:21

Merge branch 'master' into ci/bump-pt-2.6

b490968

Merge branch 'master' into ci/bump-pt-2.6

6e1f1ba

Merge branch 'master' into ci/bump-pt-2.6

daacd5d

TORCHINDUCTOR_CACHE_DIR

bc3cbd9

[pre-commit.ci] auto fixes from pre-commit.com hooks

6cfa48c

for more information, see https://pre-commit.ci

--extra-index-url=https://download.pytorch.org/whl/cpu/

0e1d047

onnx.log max_torch="2.6.0"

6946f47

github-actions bot added the docs Documentation related label Jan 7, 2025

Borda and others added 9 commits January 7, 2025 16:58

Merge branch 'master' into ci/bump-pt-2.6

6ac85c1

todo

7530f57

Merge branch 'ci/bump-pt-2.6' of https://github.com/Lightning-AI/ligh…

cb73790

…tning into ci/bump-pt-2.6

docker

26a8864

gpu

e52f392

gpu

e7d800f

check

9fb71dc

[pre-commit.ci] auto fixes from pre-commit.com hooks

daa0920

for more information, see https://pre-commit.ci

gpu

6c26f48

Borda and others added 6 commits March 11, 2025 08:59

bitsandbytes

837ef68

[pre-commit.ci] auto fixes from pre-commit.com hooks

ce5a219

for more information, see https://pre-commit.ci

external

d6cc6ad

Merge branch 'ci/bump-pt-2.6' of https://github.com/Lightning-AI/ligh…

54921ce

…tning into ci/bump-pt-2.6

_BITSANDBYTES_AVAILABLE

1895897

link

e343e6b

Borda added 5 commits March 11, 2025 10:00

bb

3d56092

bitsandbytes

be212ca

reduce-overhead

b98ed10

@pytest.mark.filterwarnings("ignore::FutureWarning")

5c021d5

not _BITSANDBYTES_AVAILABLE

a12a1ec

Borda commented Mar 11, 2025

View reviewed changes

.azure/gpu-tests-fabric.yml Outdated Show resolved Hide resolved

Borda commented Mar 11, 2025

View reviewed changes

.azure/gpu-tests-pytorch.yml Outdated Show resolved Hide resolved

Borda commented Mar 11, 2025

View reviewed changes

tests/tests_fabric/plugins/precision/test_bitsandbytes.py Outdated Show resolved Hide resolved

Borda commented Mar 11, 2025

View reviewed changes

tests/tests_pytorch/plugins/precision/test_bitsandbytes.py Outdated Show resolved Hide resolved

Borda and others added 2 commits March 11, 2025 10:35

Apply suggestions from code review

7b19eb7

RunIf(mps=False)

89c13f3

Borda force-pushed the ci/bump-pt-2.6 branch from 35a4412 to 89c13f3 Compare March 11, 2025 09:42

Borda added 2 commits March 11, 2025 11:00

test_bitsandbytes_plugin

056ed0d

reason

3a2499e

lantiga approved these changes Mar 11, 2025

View reviewed changes

_TORCH_LESS_EQUAL_2_6

84cae47

t-vi approved these changes Mar 11, 2025

View reviewed changes

mergify bot added the ready PRs ready to be merged label Mar 11, 2025

Merge branch 'master' into ci/bump-pt-2.6

eac0f94

Borda merged commit a0134d2 into master Mar 11, 2025
122 checks passed

Borda deleted the ci/bump-pt-2.6 branch March 11, 2025 13:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump: testing with latest `torch` 2.6 #20509

bump: testing with latest `torch` 2.6 #20509

Borda commented Dec 19, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading

Borda commented Mar 11, 2025

lantiga left a comment

t-vi left a comment

Borda commented Mar 11, 2025

bump: testing with latest torch 2.6 #20509

bump: testing with latest torch 2.6 #20509

Conversation

Borda commented Dec 19, 2024 • edited by github-actions bot Loading

What does this PR do?

PR review

github-actions bot commented Dec 19, 2024 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

codecov bot commented Dec 19, 2024 • edited Loading

Codecov Report

Borda commented Mar 11, 2025

lantiga left a comment

Choose a reason for hiding this comment

t-vi left a comment

Choose a reason for hiding this comment

Borda commented Mar 11, 2025

bump: testing with latest `torch` 2.6 #20509

bump: testing with latest `torch` 2.6 #20509

Borda commented Dec 19, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading