Skip to content

refactor(core): migrate to standalone Angular app #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: next
Choose a base branch
from

Conversation

dorthrithil
Copy link
Contributor

Drops all modules and updates all components etc to standalone versions.

localcrag-bot[bot]
localcrag-bot bot previously approved these changes Apr 28, 2025
@dorthrithil dorthrithil changed the title refactor(core): Migrate to standalone Angular app refactor(core): migrate to standalone Angular app Apr 28, 2025
localcrag-bot[bot]
localcrag-bot bot previously approved these changes May 11, 2025
localcrag-bot[bot]
localcrag-bot bot previously approved these changes May 11, 2025
localcrag-bot[bot]
localcrag-bot bot previously approved these changes May 14, 2025
localcrag-bot[bot]
localcrag-bot bot previously approved these changes May 14, 2025
@dorthrithil dorthrithil marked this pull request as ready for review May 16, 2025 20:33
@dorthrithil
Copy link
Contributor Author

@BlobbyBob FYI, this is basically finished now, waiting for your feature to be merged, then I'll fix the conflicts and merge this as well. After that we have a modern standalone Angular app 🥳
Maybe interesting is, that in the standalone app it's not supported anymore to use pipes inside of components. Had to refactor there and move some functionality in a service + implement the async pipe feature myself in the respective pipes.

@BlobbyBob
Copy link
Collaborator

Nice, good work 🚀

Maybe interesting is, that in the standalone app it's not supported anymore to use pipes inside of components.

How exactly do you mean that? If it's not possible to use pipes inside components, what is their use then? :D
The code changes look like you did not change a single pipe usage in HTML, but only their importing and implementations

@dorthrithil
Copy link
Contributor Author

Oh haha, that's what I meant. :D Of cause it's still possible to use them in the templates. But I got null injector errors trying to use transform of injected pipes inside the transform method of another pipe. But thinking about it again, maybe I just needed to provide them properly? Not sure anymore if I did that. Will check that again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants