Fix most spurious find definition queries when pressing the Command (macOS) or Control (Windows, Linux) keys with the cursor over some random (but not selected) text

Author: pmoura

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 * Update readme section on "Go To References" support
 * Fix spurious find definition queries when the text under the cursor is a variable
+* Fix most spurious find definition queries when pressing the Command (macOS) or Control (Windows, Linux) keys with the cursor over some random (but not selected) text
 
 ## [0.33.0]
 

README.md

@@ -373,7 +373,7 @@ VSCode doesn't support disabling menu items that are not supported by language e
 
 When the "Run and Debug" pane is closed, selecting the "Run" menu "New Breakpoint > Function Breakpoint..." item doesn't open the pane to show the new breakpoint text insertion box.
 
-VSCode triggers the "Go to Definition" computations if the cursor happens to be over some text when typing the command (macOS) or control (Windows, Linux) keys to type any keyboard command shortcut without waiting for or requiring cursor movement. It also doesn't allow overriding using the command/control keys as a keyboard shortcut for going to a definition. As a consequence, when no Logtalk terminal session exists, one is automatically created as code navigation features, including "Go to Definition", require compiling and loading the source code.
+VSCode triggers the "Go to Definition" computations if the cursor happens to be over some text when typing the command (macOS) or control (Windows, Linux) keys to type any keyboard command shortcut without waiting for or requiring cursor movement. It also doesn't allow overriding using the command/control keys as a keyboard shortcut for going to a definition. As a consequence, when some random text is selected and no Logtalk terminal session exists, one may be automatically created as code navigation features, including "Go to Definition", require compiling and loading the source code.
 
 ## Development
 

src/features/definitionProvider.ts

@@ -6,7 +6,8 @@ import {
   Location,
   Position,
   TextDocument,
-  Uri
+  Uri,
+  window
 } from "vscode";
 import LogtalkTerminal from "./logtalkTerminal";
 import { Utils } from "../utils/utils";
@@ -26,6 +27,11 @@ export class LogtalkDefinitionProvider implements DefinitionProvider {
       return null;
     }
 
+    const text = window.activeTextEditor.document.getText(window.activeTextEditor.selection);
+    if (text.length === 0) {
+      return null;
+    }
+
     await LogtalkTerminal.getDefinition(doc, position, call);
 
     const dir = path.dirname(doc.uri.fsPath);