Skip to content

Commit c3f7399

Browse files
committed
Remove load tutor tool boolean setting (use a settings file instead)
1 parent a5f6459 commit c3f7399

File tree

4 files changed

+3
-23
lines changed

4 files changed

+3
-23
lines changed

CHANGELOG.md

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
## [0.29.0]
44

55
* Label file tests and metrics data displayed using CodeLens as possibly outdated when editing the file
6-
* Add boolean setting to load the `tutor` tool at startup (default is `true`)
76
* Display `tutor` tool explanations in the "PROBLEMS" pane
87
* Fix reporting of failed tests when re-running tests
98

README.md

+2-10
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
A VSCode extension which provides language support for Logtalk. Forked from the [original plugin](https://github.com/arthwang/vsc-logtalk) by Arthur Wang.
44

5-
Requires Logtalk 3.81.0 or later and a supported [Prolog backend](https://logtalk.org/download.html#requirements).
5+
Requires Logtalk 3.86.0 or later and a supported [Prolog backend](https://logtalk.org/download.html#requirements).
66

77
🙏 Sponsored by [Permion](https://permion.ai/) and [GitHub Sponsors](https://github.com/sponsors/pmoura).
88

@@ -337,16 +337,8 @@ The number of milliseconds to wait before running the scripts that convert `.xml
337337

338338
Enables displaying inline test results (including code coverage when collected) using code lens in both the test object and the tested entity source files opened in the editor. It also enables displaying inline entity cyclomatic complexity after computing code metrics. The tests and metrics data is persistent and can be updated by re-running tests and re-computing metrics (e.g. by simply clicking in the inline data). This setting can be toggled using the "Toggle Code Lens" command.
339339

340-
#### Tutor tool integration
341-
342-
"logtalk.load.tutor": true
343-
344-
Loads the `tutor` tool when starting a terminal Logtalk session.
345-
346340
## Known Issues
347341

348-
The `tutor` tool must be loaded at startup using the "logtalk.load.tutor" boolean setting (default is `true`) instead of loaded from a Logtalk settings file.
349-
350342
Code issues detected when running the "Make - Check" or "Make - Circular" commands are displayed in the integrated terminal but not added to the "PROBLEMS" pane. But when an issue is reported in a source file, you can right click (Ctrl+click on Windows and Linux, Cmd+click on macOS) in the file path to navigate to the issue location.
351343

352344
On Windows systems, the file paths on the "PROBLEMS" pane may not be relative to the workspace directory depending on the Prolog backend. This is a consequence of some backends "normalizing" file paths in a way that breaks VSCode computing of the relative paths. E.g. paths are relative when using GNU Prolog but absolute when using SWI-Prolog or SICStus Prolog.
@@ -367,7 +359,7 @@ VSCode triggers the "Go to Definition" computations if the cursor happens to be
367359

368360
## Development
369361

370-
Developed and tested with **Logtalk 3.85.0** and **VSCode 1.95** on **macOS 14.7** and **Windows 10** with **Node 22**.
362+
Developed and tested with **Logtalk 3.86.0** and **VSCode 1.96** on **macOS 14.7** and **Windows 10** with **Node 22**.
371363

372364
After running `npm install`, `npm run vsix:make` makes the `.vsix` file and `npm run vsix:install` installs it. Restart VSCode after installation.
373365

package.json

-6
Original file line numberDiff line numberDiff line change
@@ -416,12 +416,6 @@
416416
"description": "Enables testing and code metrics results to be displayed using CodeLens.",
417417
"default": true,
418418
"order": 16
419-
},
420-
"logtalk.load.tutor": {
421-
"type": "boolean",
422-
"default": true,
423-
"description": "Load the tutor tool at startup to provide explanations and suggestions for warnings and errors.",
424-
"order": 17
425419
}
426420
}
427421
},

src/features/logtalkTerminal.ts

+1-6
Original file line numberDiff line numberDiff line change
@@ -262,12 +262,7 @@ export default class LogtalkTerminal {
262262
}
263263
});
264264

265-
let goals = ``;
266-
if (workspace.getConfiguration("logtalk").get("load.tutor", true)) {
267-
goals = `logtalk_load(['${logtalkHome}/coding/vscode/vscode.lgt',tutor(loader)], [scratch_directory('${logtalkUser}/scratch/')]).\r`;
268-
} else {
269-
goals = `logtalk_load('${logtalkHome}/coding/vscode/vscode.lgt', [scratch_directory('${logtalkUser}/scratch/')]).\r`;
270-
}
265+
let goals = `logtalk_load('${logtalkHome}/coding/vscode/vscode.lgt', [scratch_directory('${logtalkUser}/scratch/')]).\r`;
271266
LogtalkTerminal.sendString(goals, true);
272267

273268
} else {

0 commit comments

Comments
 (0)